From bf3c0a3b741f4f529380b6fe7c0f9c6b99636030 Mon Sep 17 00:00:00 2001 From: boomesh11 Date: Mon, 16 Nov 2026 17:02:16 +0530 Subject: [PATCH] fix(model): fall back to case-insensitive time column lookup in convert_to_time_column --- sqlmesh/core/model/definition.py | 10 +++++--- .../core/test_time_column_case_insensitive.py | 24 +++++++++++++++++++ 2 files changed, 31 insertions(+), 3 deletions(-) create mode 100644 tests/core/test_time_column_case_insensitive.py diff --git a/sqlmesh/core/model/definition.py b/sqlmesh/core/model/definition.py index e8e122dece..e6a7fd3dda 100644 --- a/sqlmesh/core/model/definition.py +++ b/sqlmesh/core/model/definition.py @@ -850,13 +850,17 @@ def convert_to_time_column( if columns_to_types is None: columns_to_types = self.columns_to_types_or_raise - if self.time_column.column.name not in columns_to_types: + time_column_name = self.time_column.column.name + time_column_type = columns_to_types.get(time_column_name) + if time_column_type is None: + time_column_type = {k.lower(): v for k, v in columns_to_types.items()}.get( + time_column_name.lower() + ) + if time_column_type is None: raise ConfigError( f"Time column '{self.time_column.column.sql(dialect=self.dialect)}' not found in model '{self.name}'." ) - time_column_type = columns_to_types[self.time_column.column.name] - return to_time_column( time, time_column_type, diff --git a/tests/core/test_time_column_case_insensitive.py b/tests/core/test_time_column_case_insensitive.py new file mode 100644 index 0000000000..c7951efd0e --- /dev/null +++ b/tests/core/test_time_column_case_insensitive.py @@ -0,0 +1,24 @@ +from sqlglot import exp +from sqlmesh.core.model import load_sql_based_model +from sqlmesh.core.dialect import parse + + +def test_convert_to_time_column_case_insensitive_columns_to_types(): + expressions = parse( + """ + MODEL ( + name my_schema.my_model, + dialect 'tsql,normalization_strategy=case_insensitive', + kind INCREMENTAL_BY_TIME_RANGE ( + time_column CreatedAtUtc + ) + ); + SELECT 1 AS id, CAST('2024-01-01' AS TIMESTAMP) AS createdatutc + """ + ) + model = load_sql_based_model(expressions) + result = model.convert_to_time_column( + "2024-01-02", + columns_to_types={"ID": exp.DataType.build("INT"), "CREATEDATUTC": exp.DataType.build("TIMESTAMP")}, + ) + assert isinstance(result, exp.Expr)