From 31f2a479f886e5a69bf2e2a859ec3e61c0032ac9 Mon Sep 17 00:00:00 2001 From: Xinyao Zhang <43081360+zhangxinyao88@users.noreply.github.com> Date: Thu, 19 Nov 2026 01:11:09 -0500 Subject: [PATCH] Java: Detect Objects.equals calls on arrays --- .../Likely Bugs/Comparison/EqualsArray.qhelp | 1 + .../src/Likely Bugs/Comparison/EqualsArray.ql | 14 ++++++--- .../2026-11-19-objects-equals-arrays.md | 4 +++ .../EqualsArray/EqualsArray.expected | 5 ++++ .../EqualsArray/ObjectsEquals.java | 29 +++++++++++++++++++ 5 files changed, 49 insertions(+), 4 deletions(-) create mode 100644 java/ql/src/change-notes/2026-11-19-objects-equals-arrays.md create mode 100644 java/ql/test/query-tests/EqualsArray/ObjectsEquals.java diff --git a/java/ql/src/Likely Bugs/Comparison/EqualsArray.qhelp b/java/ql/src/Likely Bugs/Comparison/EqualsArray.qhelp index dbae3e73a8b2..b52a4f24a931 100644 --- a/java/ql/src/Likely Bugs/Comparison/EqualsArray.qhelp +++ b/java/ql/src/Likely Bugs/Comparison/EqualsArray.qhelp @@ -7,6 +7,7 @@

The equals and hashCode methods on arrays only consider object identity, not array contents, which is unlikely to be what is intended. +The same applies to Objects.equals when both arguments are arrays.

diff --git a/java/ql/src/Likely Bugs/Comparison/EqualsArray.ql b/java/ql/src/Likely Bugs/Comparison/EqualsArray.ql index e206d9c89c52..7164b75087f7 100644 --- a/java/ql/src/Likely Bugs/Comparison/EqualsArray.ql +++ b/java/ql/src/Likely Bugs/Comparison/EqualsArray.ql @@ -15,13 +15,19 @@ import java from MethodCall ma, Array recvtype, Method m where - recvtype = ma.getQualifier().getType() and m = ma.getMethod() and ( - m instanceof HashCodeMethod + recvtype = ma.getQualifier().getType() and + ( + m instanceof HashCodeMethod + or + m instanceof EqualsMethod and + haveIntersection(recvtype, ma.getArgument(0).getType().(Array)) + ) or - m instanceof EqualsMethod and - haveIntersection(recvtype, ma.getArgument(0).getType().(Array)) + m.hasQualifiedName("java.util", "Objects", "equals") and + recvtype = ma.getArgument(0).getType() and + haveIntersection(recvtype, ma.getArgument(1).getType().(Array)) ) select ma, "The " + m.getName() + diff --git a/java/ql/src/change-notes/2026-11-19-objects-equals-arrays.md b/java/ql/src/change-notes/2026-11-19-objects-equals-arrays.md new file mode 100644 index 000000000000..8c15d82b2c6e --- /dev/null +++ b/java/ql/src/change-notes/2026-11-19-objects-equals-arrays.md @@ -0,0 +1,4 @@ +--- +category: minorAnalysis +--- +* The `java/equals-on-arrays` query now detects calls to `java.util.Objects.equals` with array arguments, which compare object identity instead of array contents. diff --git a/java/ql/test/query-tests/EqualsArray/EqualsArray.expected b/java/ql/test/query-tests/EqualsArray/EqualsArray.expected index 60f392f6d40e..312b45421913 100644 --- a/java/ql/test/query-tests/EqualsArray/EqualsArray.expected +++ b/java/ql/test/query-tests/EqualsArray/EqualsArray.expected @@ -1,2 +1,7 @@ +| ObjectsEquals.java:7:3:7:31 | equals(...) | The equals method on arrays only considers object identity and ignores array contents. | +| ObjectsEquals.java:8:3:8:34 | equals(...) | The equals method on arrays only considers object identity and ignores array contents. | +| ObjectsEquals.java:9:3:9:34 | equals(...) | The equals method on arrays only considers object identity and ignores array contents. | +| ObjectsEquals.java:10:3:10:37 | equals(...) | The equals method on arrays only considers object identity and ignores array contents. | +| ObjectsEquals.java:11:3:11:41 | equals(...) | The equals method on arrays only considers object identity and ignores array contents. | | Test.java:6:10:6:37 | equals(...) | The equals method on arrays only considers object identity and ignores array contents. | | Test.java:20:3:20:20 | hashCode(...) | The hashCode method on arrays only considers object identity and ignores array contents. | diff --git a/java/ql/test/query-tests/EqualsArray/ObjectsEquals.java b/java/ql/test/query-tests/EqualsArray/ObjectsEquals.java new file mode 100644 index 000000000000..9f06fb07da84 --- /dev/null +++ b/java/ql/test/query-tests/EqualsArray/ObjectsEquals.java @@ -0,0 +1,29 @@ +import java.util.Arrays; +import java.util.Objects; + +class ObjectsEquals { + void compare(int[] first, int[] second, String[] strings, Object[] objects, + int[][] nested, int[][] otherNested, long[] longs) { + Objects.equals(first, second); // $ Alert + Objects.equals(strings, objects); // $ Alert + Objects.equals(objects, strings); // $ Alert + Objects.equals(nested, otherNested); // $ Alert + java.util.Objects.equals(first, second); // $ Alert + + java.util.Objects.equals(first, null); + java.util.Objects.equals(null, first); + java.util.Objects.equals(first, longs); + java.util.Objects.equals(first, "not an array"); + java.util.Objects.equals("first", "second"); + java.util.Objects.deepEquals(first, second); + Arrays.equals(first, second); + Arrays.deepEquals(nested, otherNested); + CustomObjects.equals(first, second); + } + + static class CustomObjects { + static boolean equals(Object first, Object second) { + return java.util.Objects.deepEquals(first, second); + } + } +}