From 4ef6f0f37e9f6c5baad847368c369dec680dd466 Mon Sep 17 00:00:00 2001 From: BK <98435705+WPTK@users.noreply.github.com> Date: Sat, 21 Nov 2026 08:50:57 -0500 Subject: [PATCH 1/2] DOC: document effect of n_pvrows in pvfactors_timeseries --- docs/sphinx/source/whatsnew/v0.16.2.rst | 4 ++++ pvlib/bifacial/pvfactors.py | 7 ++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.16.2.rst b/docs/sphinx/source/whatsnew/v0.16.2.rst index fb3ff54f76..edfc009d3b 100644 --- a/docs/sphinx/source/whatsnew/v0.16.2.rst +++ b/docs/sphinx/source/whatsnew/v0.16.2.rst @@ -52,6 +52,9 @@ Documentation * Note deprecation of ``king`` model in :py:func:`~pvlib.irradiance.get_total_irradiance` and :py:func:`~pvlib.irradiance.get_sky_diffuse` docstrings. (:issue:`2897`, :pull:`2904`) +* Document the effect of ``n_pvrows`` on edge effects and runtime in + :py:func:`pvlib.bifacial.pvfactors.pvfactors_timeseries`. + (:issue:`1398`, :pull:`XXXX`) Testing @@ -84,3 +87,4 @@ Contributors * :ghuser:`xiajiahang` * Jakub Krasuski (:ghuser:`Blizzeq`) * Dylan Pulver (:ghuser:`dylanpulver`) +* :ghuser:`WPTK` diff --git a/pvlib/bifacial/pvfactors.py b/pvlib/bifacial/pvfactors.py index ec6acfc8d3..791953e49f 100644 --- a/pvlib/bifacial/pvfactors.py +++ b/pvlib/bifacial/pvfactors.py @@ -57,7 +57,12 @@ def pvfactors_timeseries( albedo: float Ground albedo n_pvrows: int, default 3 - Number of PV rows to consider in the PV array + Number of PV rows to consider in the PV array. The model treats rows + as infinite in length but finite in number, so a small ``n_pvrows`` + produces edge effects, such as fully illuminated ground under the + array at low sun elevation, which cause morning and afternoon spikes + in rear irradiance. Increasing ``n_pvrows`` reduces these effects but + significantly increases runtime. index_observed_pvrow: int, default 1 Index of the PV row whose incident irradiance will be returned. Indices of PV rows go from 0 to n_pvrows-1. From 444091a39367b252ba27444bea54a0ff6ada6d14 Mon Sep 17 00:00:00 2001 From: BK <98435705+WPTK@users.noreply.github.com> Date: Sat, 21 Nov 2026 08:56:17 -0500 Subject: [PATCH 2/2] Fill in PR number in whatsnew --- docs/sphinx/source/whatsnew/v0.16.2.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.16.2.rst b/docs/sphinx/source/whatsnew/v0.16.2.rst index edfc009d3b..c21bf17d4f 100644 --- a/docs/sphinx/source/whatsnew/v0.16.2.rst +++ b/docs/sphinx/source/whatsnew/v0.16.2.rst @@ -54,7 +54,7 @@ Documentation (:issue:`2897`, :pull:`2904`) * Document the effect of ``n_pvrows`` on edge effects and runtime in :py:func:`pvlib.bifacial.pvfactors.pvfactors_timeseries`. - (:issue:`1398`, :pull:`XXXX`) + (:issue:`1398`, :pull:`2954`) Testing