From c381f1e3ed24bce7f0ce17ca0a296c4f84585b28 Mon Sep 17 00:00:00 2001 From: "William T. Nelson" <35801+wtn@users.noreply.github.com> Date: Sun, 15 Nov 2026 15:25:39 -0600 Subject: [PATCH] Quote the test loader path in Rake::TestTask The path to rake_test_loader.rb was interpolated into the shell command unquoted, so the test task failed when rake was installed under a directory with a space in its name. Co-authored-by: Claude Mythos 5.2 --- lib/rake/testtask.rb | 2 +- test/test_rake_functional.rb | 21 +++++++++++++++++++++ test/test_rake_test_task.rb | 10 ++++++++++ 3 files changed, 32 insertions(+), 1 deletion(-) diff --git a/lib/rake/testtask.rb b/lib/rake/testtask.rb index 8ee6dfc7e..a0c5cce62 100644 --- a/lib/rake/testtask.rb +++ b/lib/rake/testtask.rb @@ -187,7 +187,7 @@ def run_code # :nodoc: when :"test-unit" "-S test-unit" when :rake - "#{__dir__}/rake_test_loader.rb" + "\"#{__dir__}/rake_test_loader.rb\"" end end diff --git a/test/test_rake_functional.rb b/test/test_rake_functional.rb index 1298a3235..7e52254ee 100644 --- a/test/test_rake_functional.rb +++ b/test/test_rake_functional.rb @@ -420,6 +420,27 @@ def test_test_task_when_verbose_unless_verbose_passed_not_prompt_testopts refute_match exp, @out end + def test_test_task_with_rake_installed_under_path_with_space + spaced_root = File.join @tempdir, "rake with space" + FileUtils.mkdir_p spaced_root + FileUtils.cp_r @rake_lib, spaced_root + @ruby_options = ["-I#{File.join spaced_root, "lib"}", "-I."] + + rakefile <<~TEST_TASK + require "rake/testtask" + + Rake::TestTask.new(:test) do |t| + t.test_files = ["a_test.rb"] + end + TEST_TASK + File.write "a_test.rb", "puts 'ATEST'\n" + + rake "test" + + assert_match(/^ATEST$/, @out) + assert_predicate @exit, :success?, @err + end + def test_comment_before_task_acts_like_desc rakefile_comments diff --git a/test/test_rake_test_task.rb b/test/test_rake_test_task.rb index 563a7e004..385e5da1c 100644 --- a/test/test_rake_test_task.rb +++ b/test/test_rake_test_task.rb @@ -191,6 +191,16 @@ def test_run_code_rake Gem.loaded_specs["rake"] = rake end + def test_run_code_rake_quotes_loader_path + test_task = Rake::TestTask.new do |t| + t.loader = :rake + end + + loader = File.expand_path("../lib/rake/rake_test_loader.rb", __dir__) + + assert_equal "\"#{loader}\"", test_task.run_code + end + def test_test_files_equals tt = Rake::TestTask.new do |t| t.test_files = FileList["a.rb", "b.rb"]