From ad073beab841ad703e322362f6869dc7faea0af3 Mon Sep 17 00:00:00 2001 From: William Bergamin Date: Mon, 16 Nov 2026 10:53:35 -0500 Subject: [PATCH] docs: standardize the pull request template and add the salesforce cla checkbox Co-Authored-By: Claude --- .github/PULL_REQUEST_TEMPLATE.md | 22 ++++++++++++++++++++++ .github/pull_request_template.md | 23 ----------------------- AGENTS.md | 2 +- 3 files changed, 23 insertions(+), 24 deletions(-) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md delete mode 100644 .github/pull_request_template.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 000000000..0efa3a2d1 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,22 @@ +### Summary + + + +### Testing + + + +### Category + +- [ ] `slack_bolt.App` and/or its core components +- [ ] `slack_bolt.async_app.AsyncApp` and/or its core components +- [ ] Adapters in `slack_bolt.adapter` +- [ ] Document pages under `/docs` +- [ ] Others + +### Requirements + +- [ ] I've read and understood the [Contributing Guidelines](https://github.com/slackapi/bolt-python/blob/main/.github/contributing.md) and have done my best effort to follow them. +- [ ] I've read and agree to the [Code of Conduct](https://slackhq.github.io/code-of-conduct). +- [ ] I have signed the [Salesforce CLA](https://cla.salesforce.com/sign-cla) (required before your PR can be reviewed or merged). +- [ ] I've run `./scripts/install_all_and_run_tests.sh` after making the changes. diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md deleted file mode 100644 index 4dcfd152a..000000000 --- a/.github/pull_request_template.md +++ /dev/null @@ -1,23 +0,0 @@ -## Summary - - - -### Testing - - - -### Category - -* [ ] `slack_bolt.App` and/or its core components -* [ ] `slack_bolt.async_app.AsyncApp` and/or its core components -* [ ] Adapters in `slack_bolt.adapter` -* [ ] Document pages under `/docs` -* [ ] Others - -## Requirements - -Please read the [Contributing guidelines](https://github.com/slackapi/bolt-python/blob/main/.github/contributing.md) and [Code of Conduct](https://slackhq.github.io/code-of-conduct) before creating this issue or pull request. By submitting, you are agreeing to those rules. - -* [ ] I've read and understood the [Contributing Guidelines](https://github.com/slackapi/bolt-python/blob/main/.github/contributing.md) and have done my best effort to follow them. -* [ ] I've read and agree to the [Code of Conduct](https://slackhq.github.io/code-of-conduct). -* [ ] I've run `./scripts/install_all_and_run_tests.sh` after making the changes. diff --git a/AGENTS.md b/AGENTS.md index 37084fa15..2ab2f9ce2 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -243,6 +243,6 @@ GitHub Actions (`.github/workflows/ci-build.yml`) runs on every push to `main` a - PRs target the `main` branch - You MUST run `./scripts/install_all_and_run_tests.sh` before submitting -- PR template (`.github/pull_request_template.md`) requires: Summary, Testing steps, Category checkboxes (`App`, `AsyncApp`, Adapters, Docs, Others) +- PR template (`.github/PULL_REQUEST_TEMPLATE.md`) requires: Summary, Testing steps, Category checkboxes (`App`, `AsyncApp`, Adapters, Docs, Others) - Requirements: CLA signed, test suite passes, code review approval - Commits should be atomic with descriptive messages. Reference related issue numbers.