Repository navigation
Do not transport Angantyr nucleus remnants, and give them a mass - #16160
Open
jackal1-66 wants to merge 1 commit into
Open
jackal1-66 wants to merge 1 commit into
jackal1-66 wants to merge 1 commit into
Conversation
This PR removes the numerous PDG warnings that Pythia8/Angantyr nucleus remnants produce in every heavy-ion job, by not flagging them for transport (which never happened anyway) and giving `O2DatabasePDG::Mass` a formula for their mass. This issue was spotted in a OO Pythia8 test with 200 events on HY in which there were 23k warnings such as this one: ``` Particle to be tracked is not defined in PDG: pdg = 1000040089 (disabling tracking) MCTrack: Cannot determine mass for pdg 1000000029 (possibly missing in TDatabasePDG) Warning in <TParticle::SetPdgCode>: PDG code 1000040089 unknown from TDatabasePDG ``` Now GeneratorPythia8::importParticles clears the kToBeDone for the remnant PDG codes. A unit test has been added for O2DatabasePDG. I tested this with the same configuration that was flooding the stdout and with pp runs (with and without Geant4).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the numerous PDG warnings that Pythia8/Angantyr nucleus remnants produce in every heavy-ion job, by not flagging them for transport (which never happened anyway) and giving
O2DatabasePDG::Massa formula for their mass. This issue was spotted in a OO Pythia8 test with 200 events on HY in which there were 23k warnings such as this one:Now GeneratorPythia8::importParticles clears the kToBeDone for the remnant PDG codes. A unit test has been added for O2DatabasePDG. I tested this with the same configuration that was flooding the stdout and with pp runs (with and without Geant4).