Skip to content

[DPG] Fix HMPID cross section tasks, use new efficiency method - #18821

Merged
vkucera merged 1 commit into
AliceO2Group:masterfrom
rliotino99:debug_acs
Nov 19, 2026
Merged

vkucera merged 1 commit into
AliceO2Group:masterfrom
rliotino99:debug_acs

Conversation

@rliotino99

Copy link
Copy Markdown
Contributor

Found some bugs in the previous versions - updated efficiency method with a new definition

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Fixing tasks - new efficiency method [DPG] Fixing tasks - new efficiency method Nov 19, 2026
@njacazio
njacazio enabled auto-merge (squash) November 19, 2026 14:46
@vkucera

vkucera commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

@rliotino99 Which tasks? Please use a comprehensive PR title.

@vkucera
vkucera disabled auto-merge November 19, 2026 14:58
@rliotino99

Copy link
Copy Markdown
Contributor Author

@rliotino99 Which tasks? Please use a comprehensive PR title.

Hello @vkucera , ok. I'm sorry. Next time I will include them in the title, I did not know this rule. The tasks are: O2Physics/DPG/Tasks/AOTTrack/PID/HMPID/hmpidAbsCrossSection.cxx and O2Physics/DPG/Tasks/AOTTrack/PID/HMPID/hmpidCrossSectionCorrections.cxx.

@vkucera

vkucera commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

@rliotino99 Which tasks? Please use a comprehensive PR title.

Hello @vkucera , ok. I'm sorry. Next time I will include them in the title, I did not know this rule. The tasks are: O2Physics/DPG/Tasks/AOTTrack/PID/HMPID/hmpidAbsCrossSection.cxx and O2Physics/DPG/Tasks/AOTTrack/PID/HMPID/hmpidCrossSectionCorrections.cxx.

You can find the contribution guidelines here. https://aliceo2group.github.io/analysis-framework/docs/gettingstarted/contributingtocode.html#pull-requests
Please read them.

@vkucera vkucera changed the title [DPG] Fixing tasks - new efficiency method [DPG] Fix HMPID cross section tasks, use new efficiency method Nov 19, 2026
@vkucera
vkucera merged commit b75d6af into AliceO2Group:master Nov 19, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants