Skip to content

[PWGCF] Add warning message regarding subgenerator id in femto producer - #18829

Merged
ariedel-cern merged 1 commit into
AliceO2Group:masterfrom
ariedel-cern:master
Nov 20, 2026
Merged

ariedel-cern merged 1 commit into
AliceO2Group:masterfrom
ariedel-cern:master

Conversation

@ariedel-cern

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwgcf label Nov 20, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@ariedel-cern
ariedel-cern marked this pull request as ready for review November 20, 2026 12:58
@ariedel-cern
ariedel-cern enabled auto-merge (squash) November 20, 2026 12:58

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ariedel-cern.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for c89da4f at 2026-11-20 14:09:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 1 warnings.'
Found 2 errors and 1 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/fa2edbe2d0b41d860588911714b0731004ebca63/O2Physics-code-check/errors.txt
PWGCF/Femto/Core/collisionBuilder.h:651:81: error: no header providing "o2::framework::HistType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Core/collisionBuilder.h:652:26: error: no header providing "TH1" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/fa2edbe2d0b41d860588911714b0731004ebca63/O2Physics-code-check/warnings.txt
PWGCF/Femto/Core/collisionBuilder.h:651:26: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

@ariedel-cern
ariedel-cern merged commit b4729f2 into AliceO2Group:master Nov 20, 2026
13 of 15 checks passed
@ariedel-cern

Copy link
Copy Markdown
Collaborator Author

Code-check errors fixed in #18834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants