Skip to content

[PWGLF] chargedParticles: pt range presets, new systematic variations, Pb-Pb axes, run QA - #18842

Merged
mario-krueger merged 3 commits into
AliceO2Group:masterfrom
mario-krueger:chargedparticles-pr2
Nov 20, 2026
Merged

mario-krueger merged 3 commits into
AliceO2Group:masterfrom
mario-krueger:chargedparticles-pr2

Conversation

@mario-krueger

Copy link
Copy Markdown
Member

No description provided.

…, Pb-Pb axes, run QA

- ptRange presets (nominal 0.15-10, lowPt from 0.05, highPt to 50 GeV/c) set bins and window together and
  replace ptMinCut/ptMaxCut; fiducialMult (default true) keeps N_ch in 0.15-10
- systMode 107 (max fraction of shared TPC clusters 0.4) and 131/132 (+kNoCollInRofStandard,
  +kNoCollInTimeRangeStandard)
- Pb-Pb/Xe-Xe multiplicity axes extended (measured 4000, true 5000)
- QA: phi per run, ITS-TPC matching monitor, shared-cluster fraction vs pT
@github-actions github-actions Bot added the pwglf label Nov 20, 2026
@github-actions github-actions Bot changed the title chargedParticles: pt range presets, new systematic variations, Pb-Pb axes, run QA [PWGLF] chargedParticles: pt range presets, new systematic variations, Pb-Pb axes, run QA Nov 20, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 1 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 2506505 at 2026-11-20 18:46:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 3 warnings.'
Found 1 errors and 3 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/d0aeb90a06207250af8c1d6de1648503810a4824/O2Physics-code-check/errors.txt
PWGLF/Tasks/Nuspex/chargedParticles.cxx:68:8: error: Excessive padding in 'struct ChargedParticles' (32 padding bytes, where 0 is optimal). Optimal fields order: pdg, evSelMask, evSelBitList, trackCutBits, metaLabel, lastRunLabel, vars, tracksPerParticle, dataRun, etaCut, fiducialMult, maxVtxZ, seedOffset, systMode, doprocessData, doprocessMC, doprocessMCnoPCC, collisionSystem, ptRange, eventClasses, evSelBits, trackSel, perCollision, histos, maxMultMeas, maxMultTrue, ptMin, ptMax, flatClass, lastRunNumber, phiRunBin, tpcCutMask, itsCutMask, trackSelFlag, trackSelMask, cutVarFlag, isRun3, enabledDirs, isNominal, isCutVar, consider reordering the fields or adding explicit padding members [clang-analyzer-optin.performance.Padding,-warnings-as-errors]
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/d0aeb90a06207250af8c1d6de1648503810a4824/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Nuspex/chargedParticles.cxx:61:34: warning: variable 'metadataInfo' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
PWGLF/Tasks/Nuspex/chargedParticles.cxx:68:8: warning: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init]
PWGLF/Tasks/Nuspex/chargedParticles.cxx:169:3: warning: initial values in enum '<unnamed>' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@mario-krueger
mario-krueger enabled auto-merge (squash) November 20, 2026 17:58

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mario-krueger.

@mario-krueger
mario-krueger merged commit 4a0adeb into AliceO2Group:master Nov 20, 2026
13 of 15 checks passed
@mario-krueger
mario-krueger deleted the chargedparticles-pr2 branch November 20, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants