Repository navigation
#143 prune docker and nginx, phase 1: disabled: lines and the soak-safe knob test - #145
Merged
Merged
Conversation
Port of CannObserv/archiver#375's _assert_clean, corrected for the skill at 063ba5db: the reader reports a passed disabled:/removed: line as soak-ended (#636), not expired-exception, so the filter matches soak-ended on a prune-stage line and keeps every other finding red, purged:'s expired-exception included (knob.md). Synthetic knobs drive it, so it fails under the old findings == [] before any stage line lands. Refs #143 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both shipped with the exeuntu image and nothing here uses them. prune.sh masked nginx.service, docker.socket, docker.service and containerd.service at 2026-11-17T21:57Z. Their exception lines carry the owner's 7-day soak: review-by 2026-11-24, so the reader reports soak-ended from 2026-11-25, the purge's prompt, clear of that day's window. Until then the probe reads both as kept, not as named:docker and dormant:nginx findings. The test pins that each carries one prune stage and no keep:. The synthetic soak lines move to components this knob never declares: a keyed exception line replaces another with the same <what>. Refs #143 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…stage strings A staggered phase 2 (one purged:, one still disabled:) sorted the stage strings into nginx, docker and failed a valid knob. Refs #143 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs #143 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Appended after a [host <glob>] header, the line would land in that scope and the soak tests would pass or fail for the wrong reason. Refs #143 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
22 of 24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 of #143: declares the dormant docker and nginx
disabled:in the patching knob, plus the ported test that keeps a prune soak's end green. The host stages already ran, each approved by the operator in this session.Refs #143
On the host (done 2026-11-17, out of any window)
autoremove_would_take=pigzonlyprune.sh --approve)nginx.servicemaskeddocker.socket,docker.service,containerd.servicemasked/var/backups/patching-hosts-prune-nginx, config.tar sha256120a38d7…/var/backups/patching-hosts-prune-docker, config.tar sha25685c544c7…Every verdict was
ok. Each run directory is root-only (700/600).The change
.skills/patching-hosts: addsexception disabled:nginx 2026-11-24 …andexception disabled:docker 2026-11-24 …, the owner's 7-day soak. The reader reportssoak-endedfrom 2026-11-25, the purge's prompt, clear of the Tue 2026-11-24 05:00–10:00Z window. Until then the probe reads both askept, with no finding.tests/test_patching_knob.py: ports Adopt patching-hosts: commit the knob, then take the first monthly run under the skill (gregoryfoster/skills#313) archiver#375's prune-soak allowance, corrected for the skill at063ba5db:disabled:/removed:line assoak-ended(#636), notexpired-exception, so the filter matchessoak-endedon a prune-stage line;purged:andkeep:included;keep:.Test evidence
findings == []. Shown by mutation this session: 3 failed.test_the_dormant_components_are_prunedfailed before the lines landed.--today 2026-11-24the knob is clean; at2026-11-25it gives twosoak-endedfindings, which the test allows.uv run pytest1063 passed, 15 skipped (the worktree's absent/etc/processorand.envfiles, and/run/docker.sock); ruff and shellcheck clean.Code review (reviewing-code-python-fastapi, blanket)
a08bd90: the declaration test compares components, so a staggered phase 2 doesn't fail a valid knob294f697: the docstring no longer pins the 7-day soak961ab93:_with_linerefuses a knob with a[host]sectiondisabled, and the host now readsmasked. Phase 2 retires it, per the brief's scopeDeploy
.skills/patching-hostsis aRUNTIME_FILESpath, so this needsscripts/deploy.shafter the merge (a few seconds' restart; no window needed).🤖 Generated with Claude Code