Repository navigation
fix(nginx-proxy): update nginx to 1.31.9 for the 1.31.7 and 2026-11-18 security fixes - #379
Merged
mrrobot47 merged 2 commits intoNov 19, 2026
Conversation
jwilder/nginx-proxy 1.11.6 is still the latest nginx-proxy release and ships nginx 1.31.3. nginx 1.31.6 and 1.31.7 fixed six CVEs since then, among them CVE-2026-93479, a buffer overflow while evaluating string expressions with variables, which covers the variable-based vhost log_format every proxied site uses. The build-time apt-get upgrade can't pick up nginx because the official nginx image removes its nginx.org apt source. Re-add the nginx.org mainline source after the Debian upgrade, install the same pinned package set as the official nginx:1.31.8 image (nginx and its xslt, geoip, image-filter, njs and acme modules), and remove the source again. Drop this once an nginx-proxy release ships nginx 1.31.8 or newer; a newer base makes the pinned install fail instead of downgrading.
|
No actionable comments were generated in the recent review. Walkthrough
Change: Bug fix Merge Risk:
|
…fixes nginx 1.31.8 is still vulnerable to the 2026-11-18 advisories. The ones the proxy is exposed to are the HTTP/2 use-after-free (CVE-2026-123633) and flow-control memory corruption (CVE-2026-123007), since `nginx.tmpl` enables `http2` on every 443 server, the infinite loop reading a client request body over TLS 1.3 (CVE-2026-118899), and the resolver use-after-free (CVE-2026-123634). 1.31.9 fixes them. `ACME_VERSION` moves to 0.4.2 because nginx.org has no 1.31.9 build of nginx-module-acme with 0.4.1, only `1.31.9+0.4.2`. This matches the official nginx 1.31.9 image. Refs EasyEngine/easyengine#1966
mrrobot47
added a commit
to EasyEngine/easyengine
that referenced
this pull request
Nov 19, 2026
Move easyengine/nginx-proxy to v4.14.1, which updates its nginx from 1.31.3 to 1.31.9 for the nginx security fixes of 2026-11-18 (CVE-2026-123633, CVE-2026-123007, CVE-2026-118899, CVE-2026-123634) and the earlier 1.31.6 and 1.31.7 fixes (EasyEngine/dockerfiles#379). The other images are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jwilder/nginx-proxy:1.11.6(2026-07-16) is still the latest nginx-proxy release, and it ships nginx 1.31.3. Upstreammainis on 1.31.6 and the 1.31.7, 1.31.8 and 1.31.9 bumps are still open there, so no release has the fixes yet.nginx security fixes since 1.31.3 (https://nginx.org/en/security_advisories.html, https://nginx.org/en/CHANGES):
nginx.tmplsetshttp2 onin each 443 block; CVE-2026-118899 (infinite loop reading a client request body over TLS 1.3); CVE-2026-123634 (use-after-free in resolver responses). Also fixed: CVE-2026-125283 (aliaswithtry_files), CVE-2026-121810 (HTTP/3), CVE-2026-113425 (mail proxy), CVE-2026-120993 (PROXY protocol v2), CVE-2026-120967 and CVE-2026-123640 (stream).vhostlog_format is variable-based), CVE-2026-15176 (aliasafterrewrite), CVE-2026-95101 (HTTP/3), CVE-2026-97629 (TLS session ticket rotation; we setssl_session_tickets off), CVE-2026-97205 (AIO with SSI).The
apt-get upgradefrom #369 doesn't reach nginx because the official nginx image removes its nginx.org apt source. This re-adds the source (signed by the keyring the base image keeps), installs the same pinned set as the officialnginx:1.31.9image (nginx 1.31.9 with xslt, geoip, image-filter, njs 1.0.2 and acme 0.4.2 modules), and removes the source again.NGINX_VERSION/NJS_VERSION/ACME_VERSIONare set so the image env matches what's installed.ACME_VERSIONmoves from the base image's 0.4.1 to 0.4.2 because nginx.org has no 1.31.9 acme module build with 0.4.1.Once an nginx-proxy release ships nginx 1.31.9 or newer, bump the FROM and drop this block. With a newer nginx in the base, the pinned install fails instead of downgrading.
Refs EasyEngine/easyengine#1966
Testing
nginx -v1.31.9 (develop builds 1.31.3),nginx -tpasses with ournginx.confand with all seven dynamic modules loaded (http acme, geoip, image_filter, js, xslt_filter; stream geoip, js), ournginx.confis unchanged after the upgrade,apt list --upgradableis empty and no nginx.org source is left in the image.htpasswd, docker-gen 0.17.2 and forego present,/version.confunchanged; the default page is served withX-Powered-By: EasyEngine v4.nginx.tmplfor a backend withVIRTUAL_HOST=smoke.test,nginx -tpasses, and a request withHost: smoke.testthrough the proxy reaches the backend.http2 on, ALPN negotiatesh2and an HTTP/2 request is proxied to the backend (200), an HTTP/1.1 request over TLS is proxied too, and plain HTTP gets the 301 redirect to HTTPS.Summary by CodeRabbit