Skip to content

fix(nginx-proxy): update nginx to 1.31.9 for the 1.31.7 and 2026-11-18 security fixes - #379

Merged
mrrobot47 merged 2 commits into
EasyEngine:developfrom
mrrobot47:fix/nginx-proxy-nginx-1.31.8
Nov 19, 2026
Merged

mrrobot47 merged 2 commits into
EasyEngine:developfrom
mrrobot47:fix/nginx-proxy-nginx-1.31.8

Conversation

@mrrobot47

@mrrobot47 mrrobot47 commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

jwilder/nginx-proxy:1.11.6 (2026-07-16) is still the latest nginx-proxy release, and it ships nginx 1.31.3. Upstream main is on 1.31.6 and the 1.31.7, 1.31.8 and 1.31.9 bumps are still open there, so no release has the fixes yet.

nginx security fixes since 1.31.3 (https://nginx.org/en/security_advisories.html, https://nginx.org/en/CHANGES):

The apt-get upgrade from #369 doesn't reach nginx because the official nginx image removes its nginx.org apt source. This re-adds the source (signed by the keyring the base image keeps), installs the same pinned set as the official nginx:1.31.9 image (nginx 1.31.9 with xslt, geoip, image-filter, njs 1.0.2 and acme 0.4.2 modules), and removes the source again. NGINX_VERSION/NJS_VERSION/ACME_VERSION are set so the image env matches what's installed. ACME_VERSION moves from the base image's 0.4.1 to 0.4.2 because nginx.org has no 1.31.9 acme module build with 0.4.1.

Once an nginx-proxy release ships nginx 1.31.9 or newer, bump the FROM and drop this block. With a newer nginx in the base, the pinned install fails instead of downgrading.

Refs EasyEngine/easyengine#1966

Testing

  • Built locally: nginx -v 1.31.9 (develop builds 1.31.3), nginx -t passes with our nginx.conf and with all seven dynamic modules loaded (http acme, geoip, image_filter, js, xslt_filter; stream geoip, js), our nginx.conf is unchanged after the upgrade, apt list --upgradable is empty and no nginx.org source is left in the image.
  • Debian 13.7, OpenSSL 3.5.7, htpasswd, docker-gen 0.17.2 and forego present, /version.conf unchanged; the default page is served with X-Powered-By: EasyEngine v4.
  • Full entrypoint with the Docker socket mounted: docker-gen renders nginx.tmpl for a backend with VIRTUAL_HOST=smoke.test, nginx -t passes, and a request with Host: smoke.test through the proxy reaches the backend.
  • HTTPS with a self-signed certificate for a test host: the rendered 443 block has http2 on, ALPN negotiates h2 and an HTTP/2 request is proxied to the backend (200), an HTTP/1.1 request over TLS is proxied too, and plain HTTP gets the 301 redirect to HTTPS.
  • The nginx.org packages exist at these versions for arm64 too, so this works with the multi-arch build in feat: build and publish every image for linux/amd64 and linux/arm64 #373.

Summary by CodeRabbit

  • Updates
    • The proxy container now uses fixed versions of NGINX, NJS, and ACME components for more consistent builds.
    • Added support for XSLT, GeoIP, and image-filter functionality in the proxy.
    • The previous web server utility is no longer included.

jwilder/nginx-proxy 1.11.6 is still the latest nginx-proxy release and ships nginx 1.31.3. nginx 1.31.6 and 1.31.7 fixed six CVEs since then, among them CVE-2026-93479, a buffer overflow while evaluating string expressions with variables, which covers the variable-based vhost log_format every proxied site uses. The build-time apt-get upgrade can't pick up nginx because the official nginx image removes its nginx.org apt source.

Re-add the nginx.org mainline source after the Debian upgrade, install the same pinned package set as the official nginx:1.31.8 image (nginx and its xslt, geoip, image-filter, njs and acme modules), and remove the source again. Drop this once an nginx-proxy release ships nginx 1.31.8 or newer; a newer base makes the pinned install fail instead of downgrading.
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Changes: NGINX package installation

Layer / File(s) Summary
Repository setup and package installation
nginx-proxy/Dockerfile
The Dockerfile defines NGINX, NJS, and ACME versions, adds the NGINX mainline Debian repository, installs NGINX and its listed modules at specified versions, and removes apt lists and repository configuration.

Suggested reviewers: jeffreyvdhondel

Change: Bug fix

Merge Risk: Minimal · up to c286d

The proxy image now installs pinned NGINX packages from the NGINX mainline repository instead of relying on the base image's version. No concrete merge-blocking risk was found. A normal image build confirms the pinned packages resolve.

Architecture risk: Low · up to c286d

The change affects 1 system.

Changed systems: nginx-proxy

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — nginx-proxy (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in nginx-proxy/Dockerfile: Adds version variables for NGINX 1.31.9, NJS 1.0.2, and ACME 0.4.2, with comments identifying the package update and security-fix versions.
  • observed — Modified behavior in nginx-proxy/Dockerfile: The build still updates and upgrades Debian packages and installs apache2-utils, but replaces the immediate package-index cleanup with adding the NGINX mainline Trixie repository, refreshing package metadata, and installing pinned NGINX and module packages. It then removes both the package index and the temporary repository list.
Finishing Touches

Generate unit tests (beta)

  • Create a new PR
Fix failing CI checks

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cdf98349-e7f5-400d-8205-dee2d1ad3974
Commits

Reviewing files that changed from the base of the PR and between baf9396 and c286d0a.

Files selected for processing: 1

  • nginx-proxy/Dockerfile

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

…fixes

nginx 1.31.8 is still vulnerable to the 2026-11-18 advisories. The ones the proxy is exposed to are the HTTP/2 use-after-free (CVE-2026-123633) and flow-control memory corruption (CVE-2026-123007), since `nginx.tmpl` enables `http2` on every 443 server, the infinite loop reading a client request body over TLS 1.3 (CVE-2026-118899), and the resolver use-after-free (CVE-2026-123634). 1.31.9 fixes them.

`ACME_VERSION` moves to 0.4.2 because nginx.org has no 1.31.9 build of nginx-module-acme with 0.4.1, only `1.31.9+0.4.2`. This matches the official nginx 1.31.9 image.

Refs EasyEngine/easyengine#1966
@mrrobot47 mrrobot47 changed the title fix(nginx-proxy): update nginx to 1.31.8 for the 1.31.7 security fixes fix(nginx-proxy): update nginx to 1.31.9 for the 1.31.7 and 2026-11-18 security fixes Nov 19, 2026
@mrrobot47
mrrobot47 merged commit ffcd7e8 into EasyEngine:develop Nov 19, 2026
10 of 15 checks passed
@mrrobot47
mrrobot47 deleted the fix/nginx-proxy-nginx-1.31.8 branch November 19, 2026 08:45
mrrobot47 added a commit to EasyEngine/easyengine that referenced this pull request Nov 19, 2026
Move easyengine/nginx-proxy to v4.14.1, which updates its nginx from 1.31.3 to 1.31.9 for the nginx security fixes of 2026-11-18 (CVE-2026-123633, CVE-2026-123007, CVE-2026-118899, CVE-2026-123634) and the earlier 1.31.6 and 1.31.7 fixes (EasyEngine/dockerfiles#379). The other images are unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant