Repository navigation
Conversation
Add php/8.6, based on php/8.5, on the php:8.6.0RC7-fpm base until the 8.6.0 GA image is on Docker Hub. The 8.6 base image differs from 8.5's in three ways that need changes here: - It has no pecl or PEAR (docker-library/php#1654), so memcached, redis, apcu and timezonedb are built from source tarballs with docker-php-ext-install, and the extension RUN uses set -eux so a failed extension fails the build instead of being skipped. - mbstring is no longer compiled in, so it is installed as an extension (with libonig-dev). - It is built with ZTS (docker-library/php#1686). The latest PECL releases of memcached (3.4.0), redis (6.3.0) and apcu (5.1.28) don't build on 8.6, so the upstream commits that fix the build are pinned. mcrypt and imap don't build on 8.6 even from their upstream heads, so they are commented out, with the sury libc-client-dev step imap needed. Opcache is always compiled in since 8.5, so it is no longer installed as an extension. The New Relic agent stays disabled as on 8.5: its newest release has no build for 8.6's module API (20261112) or for ZTS. The commented download already uses the lookup that only matches the tarball. php.ini is 8.5's, without the deprecated session.sid_length and session.sid_bits_per_character settings.
Add 8.6 to the PHP build matrix and a Dependabot entry for php/8.6, like 8.5.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
easyengine/php8.6image (php/8.6), based onphp/8.5.Draft until PHP 8.6.0 GA is on Docker Hub. There is no
php:8.6.0-fpmorphp:8.6-fpmtag yet, so the image is built onphp:8.6.0RC7-fpm, the newest RC. It moves to the 8.6.0 GA tag once that is published (and the extension pins below are re-checked then).This PR also edits
.github/workflows/test_and_publish.yml(adds'8.6'to the PHP matrix) and.github/dependabot.yaml(aphp/8.6entry likephp/8.5's).What differs from php/8.5
The 8.6 base image changed in three ways that affect this Dockerfile:
--with-pearwith PHP 8.6 docker-library/php#1654).pecl installdoesn't exist, so the PECL extensions are built from source tarballs withdocker-php-ext-install. The extensionRUNstarts withset -eux, so a failed extension fails the build. On 8.5 the;chain hides such failures.docker-php-ext-install mbstring(pluslibonig-dev).Extensions:
0b52d365(reports 3.4.1dev): 3.4.0 doesn't build on 8.6 (XtOffsetOf,zval_dtorremoved); fixed in php-memcached-dev/php-memcached#580, not released yetdevelophead5b60b125(reports 6.3.0RC1): 6.3.0 doesn't build on 8.6fb2c9425(reports 5.1.29-dev): 5.1.28 doesn't build on 8.6libc-client-devstep it needed is commented out toodocker-php-ext-install opcache(fails silently, opcache is built in since 8.5)The memcached, redis and apcu sources are pinned by full commit SHA. Their builds are unreleased upstream code, so they should move to the first releases that support 8.6.
New Relic: stays disabled, as on 8.5. The latest agent (12.13.0.43) has no module for 8.6's API (20261112), and it has no ZTS build at all. The commented download line already uses the fixed lookup (
grep 'linux\.tar\.gz"' | head -n 1).php.ini,easyengine.conf,bashrc,expose_off.ini,newrelic.inianddocker-entrypoint.share copies of 8.5's, sophp.inihas nosession.sid_length/session.sid_bits_per_character.Behaviour change from PHP itself: 8.6 defaults
session.cookie_samesitetoLax(8.5: empty), and the image'sphp.inidoesn't set it, so session cookies now carrySameSite=Lax.Testing
Built locally with
docker build -t easyengine/php8.6:test php/8.6(amd64 only) and compared witheasyengine/php8.5:v4.14.0:php -v:PHP 8.6.0RC7 (cli) (ZTS), with Zend OPcache.php -m: the same modules as the 8.5 image exceptimapandmcrypt.error_reporting=-1anddisplay_startup_errors=1. Every directive the shippedphp.inisets that 8.5 knows is also known on 8.6.php-fpm -tpasses. php-fpm started through the image's entrypoint serves FastCGI requests (sessions, mbstring, redis, memcached, apcu, imagick, opcache all working) and its error log has only the usual startup notices, the same as on 8.5.wp --version(WP-CLI 2.12.0) andcomposer --versionrun.