Skip to content

fix(migration): wait up to 180 s for global services during updates - #1968

Open
mrrobot47 wants to merge 1 commit into
EasyEngine:developfrom
mrrobot47:fix/global-ready-timeout-180
Open

mrrobot47 wants to merge 1 commit into
EasyEngine:developfrom
mrrobot47:fix/global-ready-timeout-180

Conversation

@mrrobot47

@mrrobot47 mrrobot47 commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Raise the default time a recreated global service (nginx-proxy, redis, cron, newrelic-daemon) gets to become ready during an update from 60 s to 180 s (GlobalContainers::READY_TIMEOUT).
  • On a slow or heavily loaded server the new nginx-proxy can take longer than 60 s to pass its readiness probe (nginx -t, a response on port 80, then a 2 s settle). The update then rolls back to the previous proxy and ee cli update fails, although nothing is wrong except speed.
  • Unchanged: the database keeps its 300 s, and global-service-ready-timeout in config.yml still overrides both. A healthy proxy is still accepted as soon as it is ready (2–3 s in the v4.14.1 upgrade tests), so normal updates don't get slower. Only a proxy that never comes up now takes up to 180 s before the rollback, instead of 60 s.

Planned for v4.14.2.

Testing

  • php -l passes. The only change is the constant; the timeout logic and its config override are unchanged from v4.14.0.

Summary by CodeRabbit

  • Bug Fixes
    • The default wait time for global services to become ready is now three minutes, up from one minute. A positive numeric global-service-ready-timeout setting can still override this default. The database readiness timeout remains unchanged at five minutes.

A recreated global service (nginx-proxy, redis, cron, newrelic-daemon) got 60 s to become ready before the update rolled back. Slow or heavily loaded servers can take longer, so raise the default to 180 s. The database keeps its 300 s, and `global-service-ready-timeout` in config.yml still overrides both.
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Changes: Global service readiness

Layer / File(s) Summary
Readiness timeout default
php/EE/Migration/GlobalContainers.php
READY_TIMEOUT increases from 60 to 180 seconds. The database-specific timeout and configured override remain unchanged.

Possibly related PRs

Change: Bug fix

Merge Risk: Minimal · up to 05485

This raises the default wait for global services to become ready during updates from 60 to 180 seconds, so slow servers are less likely to hit a spurious rollback. Healthy updates are not slowed. A service that never becomes ready now takes longer to trigger rollback. The change is low risk and ready to merge.

Security architecture risk: Minimal · up to 05485

The longer default wait changes update and rollback timing without changing service permissions, readiness checks, or recovery ordering. No introduced security exposure or broken recovery guarantee was established.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The availability scope is shared host infrastructure: a non-ready global proxy can affect every site using that proxy, and the longer default can postpone rollback initiation. The inspected change does not expand that service scope or establish new attacker-controlled reachability.

Trust Boundaries and Controls

  • observed — The existing proxy probe checks nginx configuration and an HTTP response through the configured published port. Its curl request bypasses environment HTTP proxies. Redis readiness accepts either PONG or an authentication-required response; this is an unchanged liveness check, not a change to authentication enforcement.
Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 08d7dece-6db9-4ccd-88e0-242f157b5962
Commits

Reviewing files that changed from the base of the PR and between 512b43e and 054850c.

Files selected for processing: 1

  • php/EE/Migration/GlobalContainers.php

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant