Repository navigation
Conversation
…che error Since the reload refuses a config its own nginx -t rejects, update_proxy_cache() also reaches the enable-failed error and the disable warning when the earlier test passed. Both then appended that passing test's "syntax is ok ... test is successful" output, while the real failure was only in the reload's warning just above. The output is now appended only when that test failed, and the disable path says the proxy was not reloaded.
… a refused reload The removal already reloaded the proxy once, so "The proxy was not reloaded" could be false; the refused reload's own test output is in the warning just above.
|
No actionable comments were generated in the recent review. Walkthrough
Change: Bug fix Merge Risk:
|
Since the proxy reload refuses a config its own
nginx -trejects,update_proxy_cache()also reaches the "Could not enable proxy cache ..." error and the disable path's "nginx config test failed after disabling proxy cache" warning when the earliernginx -tpassed. Both then appended that passing test's "syntax is ok ... test is successful" output, while the real failure was only in the reload's warning printed just above.The test output is now appended only when that test failed. Otherwise the enable error and the disable warning point at the refused reload's warning above.
Tested with PHPUnit on PHP 7.4 and 8.5: after a refused reload, the enable error and the disable warning no longer carry the passing test's output and point at the reload warning, and a failing test's output is still appended.
Summary by CodeRabbit