Skip to content

Add ability to specify page size when creating database. - #53

Merged
P1cheneG merged 3 commits into
FirebirdSQL:mainfrom
P1cheneG:allow_to_create_database_with_custom_page_size
Nov 20, 2026
Merged

P1cheneG merged 3 commits into
FirebirdSQL:mainfrom
P1cheneG:allow_to_create_database_with_custom_page_size

Conversation

@P1cheneG

Copy link
Copy Markdown
Contributor

Resolves #50

@P1cheneG
P1cheneG requested a review from MrTeeett November 19, 2026 10:59
@P1cheneG P1cheneG self-assigned this Nov 19, 2026
Comment thread fbconn/fbconn.go Outdated
dpb.PutInt32(fbproto.Isc_dpb_sql_dialect, 3)
if config.CreateDatabase {
dpb.PutInt32(fbproto.Isc_dpb_set_db_sql_dialect, 3)
if !isValidPageSize(config.PageSize) && config.PageSize != 0 {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configuration is verified after a network connection is established

I think the check should be moved to the general connectConfig, before the DNS and connection.

@P1cheneG
P1cheneG merged commit 0bb8b63 into FirebirdSQL:main Nov 20, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to create database with custom page size

2 participants