Repository navigation
Fix #9328: AT TIME ZONE / AT LOCAL with a non-TIME/TIMESTAMP argument reports only "expression evaluation not supported" - #9329
Open
vmzubov wants to merge 1 commit into
Conversation
…MP argument reports only "expression evaluation not supported" Add a secondary status with the expected and the actual data type, keeping isc_expression_eval_err as the primary error. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9328.
AtNode::make()andAtNode::execute()raised a bareisc_expression_eval_err(marked//// TODO: more info) when the argument was not TIME or TIMESTAMP.Changes:
isc_at_argmustbe_time_timestamp(JRD 1028,Argument for AT TIME ZONE or AT LOCAL must be of type TIME or TIMESTAMP, but @1 was given);isc_expression_eval_err, so the primary error code and SQLSTATE 42000 stay the same (same pattern asisc_sysf_argmustbe_*in SysFunction.cpp);src/include/gen/Firebird.pasupdated with the new constant.Before:
After:
Tested on Linux x64 (clang):
make,make tests,make run_tests; manual check with DATE, INTEGER, and the regular TIME/TIMESTAMP cases (unchanged).The patch was prepared with the help of Claude (AI assistant); I reviewed and tested it and take responsibility for it.