Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug described in #9333
With
SubQueryConversion = truea correlated EXISTS / IN sub-query became a semi-join even when it referred to an outer stream only from inside a nested record source (a derived table, an aggregate, a union, a window,DISTINCTorORDER BY).rse->collectStreams()does not walk these parts. The inner side was evaluated without the outer record and the query returned a wrong result.findPossibleJoins()now checks the sub-query with collectAllStreams().findDependentBooleans()does not take an equality that refers to an outer stream or to a stream of the sub-query itself only through a nested record source.Plain correlated EXISTS / IN sub-queries are converted as before.