Repository navigation
fix: reminder labels and wording, readable search tab for custom sources - #3453
MartinCupela wants to merge 4 commits into
Conversation
β¦anslate fallbacks - The RemindMe action is labelled "Remove Reminder" when the message has a reminder and "Remind Me Message" when it does not. - ReminderNotification reads "Due since β¦" as soon as the deadline passes, not only past the timer's two-week stop-refresh boundary. - The reminder and save-for-later error fallbacks go through t() with new keys: messageActions.errorRemovingReminder.text, messageActions.errorRemovingSaveLater.text, messageActions.errorSavingLater.text and messageActions.remindMeSubmenu.errorSettingReminder.text. Ticket: https://linear.app/stream/issue/REACT-1284
β¦or keys The vite example's dictionaries must list every SDK key, or its build fails. Ticket: https://linear.app/stream/issue/REACT-1284
β¦ults provider - A custom search source's filter tab shows the source's type until the app translates its label key, instead of the raw key. - useSearchSourceResultsContext's error names SearchSourceResultsContextProvider, the exported component. Ticket: https://linear.app/stream/issue/REACT-1304
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Size Change: +359 B (+0.03%) Total Size: 1.1 MB π¦ View Changed
βΉοΈ View Unchanged
|
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3453 +/- ##
==========================================
+ Coverage 91.31% 91.35% +0.04%
==========================================
Files 643 643
Lines 21245 21246 +1
Branches 6719 6718 -1
==========================================
+ Hits 19399 19410 +11
+ Misses 1846 1836 -10 β View full report in Codecov by Harness. π New features to boost your workflow:
|
Tickets:
π― Goal
Fix the reminder and search UI issues found while writing the v15 docs. Nothing here changes the public API, and no translation key is renamed.
π Implementation details
REACT-1284: reminders
RemindMe labels: the action's aria-labels were swapped. It now reads "Remove Reminder" when the message has a reminder and "Remind Me Message" when it doesn't.
"Due since":
ReminderNotificationused the "Due since" prefix only once a reminder was more than two weeks overdue (the timer's stop-refresh boundary). It now uses it as soon as the deadline passes:Error fallbacks: the hard-coded English fallbacks in
RemindMeSubmenuand the RemindMe / SaveForLater actions go throught()with four new keys:messageActions.errorRemovingReminder.textmessageActions.errorRemovingSaveLater.textmessageActions.errorSavingLater.textmessageActions.remindMeSubmenu.errorSettingReminder.textThe vite example's German and Italian dictionaries get matching copy in a separate commit.
REACT-1304: search
search-results-header-filter-source-button-label--<type>until the app translated it. It now shows the source's type; an app translation of that key still wins.useSearchSourceResultsContexterror now namesSearchSourceResultsContextProvider, the exported component. The hook table inai-docs/ai-migration-v14-v15.mdis updated to match.idnote is gone fromSearch, and theinputPropsprecedence is documented.Release note: apps that translate
message.reminderNotification.dueSince.labelnow also get relative times in it ("Due since 5 minutes ago"), not only dates.Tests: exact reminder text for every case with a pinned clock, both RemindMe labels, translated error fallbacks, the custom-source tab label and the provider name in the error.
Docs follow-up (getstream.io):
docs/chat-sdk/react/v15-latest/04-features/03-channels/04-search.mdshould say the tab shows the source's type until the app translates the label key.π¨ UI Changes
Text and aria-label changes only, listed above. No layout or styling changes.
Summary by CodeRabbit