Skip to content

test: remove webhook test pinned to rotated app secret - #397

Open
szuperaz wants to merge 1 commit into
mainfrom
remove-webhook-tests
Open

szuperaz wants to merge 1 commit into
mainfrom
remove-webhook-tests

Conversation

@szuperaz

@szuperaz szuperaz commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Issue link: https://github.com/GetStream/secret-rotation/issues/64

`tests/integration/webhook.test.ts` hardcoded a signature that was computed with the test app's old secret. Since the secret was rotated, `verify webhook - user.updated` fails on every runtime (see #396).

This PR removes the file. Nothing loses coverage: `webhook-compression.test.ts` already tests `client.verifyWebhook` with a valid and an invalid signature, plus the lower-level `verifySignature` checks. Those tests use a fixed fake secret, so secret rotation can't break them.

🤖 Generated with Claude Code

The test hardcoded a signature computed with the test app's old secret,
so it fails after secret rotation. webhook-compression.test.ts already
covers verifyWebhook with valid and invalid signatures using a fixed
fake secret.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@szuperaz
szuperaz requested a review from oliverlaz as a code owner November 17, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant