Repository navigation
Implement kernels for median and paritition functions
#3138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ndgrigorian
wants to merge
42
commits into
master
Choose a base branch
from
feature/implement-median-partition-fns
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,114
−810
Open
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
50ff129
Implements kernels for median and partition functions
ndgrigorian 54a02da
Report the coverage of dpnp.partition's kernel
ndgrigorian a020d93
Instrument only the host code of the radix select sources
ndgrigorian 072d4c5
Avoid an all-NaN row in TestNanMedianSelect::test_basic
ndgrigorian 89c1548
Check the shape of out in the select path of median and nanmedian
ndgrigorian 454829f
Test the queue and USM type of partition and argpartition results
ndgrigorian 2a53a17
Validate the inputs of _median and _partition for an empty batch
ndgrigorian 270de0f
Add the changelog entries of argpartition and the radix select
ndgrigorian 78e8708
Accept an out of the keepdims shape in median and nanmedian
ndgrigorian 98140a9
Give -0.0 the radix key of +0.0 by comparing keys
ndgrigorian f18976f
Order the all_nan fill of the empty-batch median test after its creation
ndgrigorian b062b0b
Instrument only the host code of the whole _statistics_impl module
ndgrigorian 4470cbd
Average the two medians of an even row even when they are equal
ndgrigorian cd93054
Reject src and dst sharing memory in _partition and _argpartition
ndgrigorian 99a518d
Validate kth of partition and argpartition as NumPy does
ndgrigorian 5acf814
Say overwrite_input may modify the input of median and nanmedian
ndgrigorian 8ae8eed
Remove dpnp_less_comp and the backend partition mentions
ndgrigorian e1d2e7c
Ignore NumPy's intended overflow in the special-value median tests
ndgrigorian ba9559d
Wait for the all_nan fill of _median if the selection throws
ndgrigorian 8d0e22c
Reject an all_nan sharing memory with src or dst in _median
ndgrigorian 673c5d5
Make is_median_type_pair a variable template, which llvm-cov doesn't …
ndgrigorian 658573c
Filter top_k only after the first pass of the multi-group radix selec…
ndgrigorian 2d11f72
Keep the per work-group maxima of the median with the counts rather t…
ndgrigorian e3f2077
Say sub-group rows of radix_partition_impl come out sorted
ndgrigorian 74012ee
Warn in the nanmedian docstring that it synchronizes
ndgrigorian 53d7012
Cast the medians to out unsafely, so complex nanmedian accepts an out…
ndgrigorian f25c1b6
Run the out, all-NaN and usm_ndarray median tests with complex input …
ndgrigorian 5221066
Read the all-NaN flag of nanmedian in place from host USM
ndgrigorian bfa363c
Fill the median of an empty array with NaN, without selecting or sorting
ndgrigorian d57c060
Link dpnp.argpartition from dpnp.top_k and ndarray.argsort
ndgrigorian 31e554d
Fix the ndarray.partition docstring: a Parameters heading, a link and…
ndgrigorian 0e15349
Say partition selects only for a single kth in the changelog
ndgrigorian 6dae1f5
Build partition.cpp with -fno-fast-math, as topk.cpp in the same module
ndgrigorian a38a786
Add the \file blocks to the partition and median sources
ndgrigorian 066d95f
Keep the all-NaN flag of nanmedian in host USM only where the device …
ndgrigorian 6e97941
Copy the all-NaN flag of nanmedian from device USM once the median is…
ndgrigorian e89503e
Round the median of an even integer row once, also to float32 on devi…
ndgrigorian d6b32d0
Take the multi-group radix select on a GPU only for fewer rows than a…
ndgrigorian ca7c45f
Partition short rows of 4- and 8-byte integers and float32 on a GPU b…
ndgrigorian c465270
Merge branch 'master' into feature/implement-median-partition-fns
ndgrigorian b264b52
Say which rows radix_partition_impl doesn't keep in their order: thos…
ndgrigorian fb76976
Write a partitioned element of radix select with one store rather tha…
ndgrigorian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.