Repository navigation
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PaulHax
force-pushed
the
volume-modality-defaults
branch
2 times, most recently
from
November 14, 2026 20:17
df33372 to
d2dfe58
Compare
Read the modality of non-DICOM images from header metadata (DICOM-style tag, modality field, MetaImage MET_MOD_* names) and treat Hounsfield scalar units as CT. MR volumes now default to the MR-Default preset.
… modality ITK reports MET_MOD_UNKNOWN for every MetaImage that sets no modality, which hid the Hounsfield units fallback.
PaulHax
force-pushed
the
volume-modality-defaults
branch
from
November 17, 2026 02:47
89da1dd to
d032341
Compare
Collaborator
Author
|
Superseded by #1039, which reworks this series into a smaller design: fitted presets use the existing image statistics, the opacity editor keeps the data range as its axis for every preset, and the default modality comes from DICOM only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of five small PRs that replace #1003.
The default 3D preset now follows the declared modality for more inputs:
MR-Defaultinstead ofCT-Coronary-Arteries-2, which Minor style and default tweaks #244 chose without a stated reason. Coronary CT opacity is defined in Hounsfield units, which MR intensities are not. feat(volume-rendering): fit a grayscale default to untagged volumes #1028 then maps the MR presets onto each volume's data range.modalityor0008|0060fields, MetaImageMET_MOD_*values).When no modality is given, Hounsfield scalar units imply CT. That selects
CT-AAA, the current default, so it only changes the result once #1028 fits a default to untagged volumes.Images with no declared modality keep
CT-AAA. NIfTI and VTI files expose no modality, so they are unaffected here.DEFAULT_PRESET_BY_MODALITYis shared with layer coloring, so a multicomponent DICOM MR layer also defaults toMR-Default.