Skip to content

Sidebar: a page can be dropped below another, so it can go last - #217

Open
LoopyDev wants to merge 1 commit into
mainfrom
fix/sidebar-drop-last
Open

LoopyDev wants to merge 1 commit into
mainfrom
fix/sidebar-drop-last

Conversation

@LoopyDev

Copy link
Copy Markdown
Owner

A page couldn't be moved to the bottom of a list in the sidebar. A row only took a page above it (its top fifth) or into it (the rest), so nothing could go after the last page. Scan item 3.24's first half.

  • Each row now has three zones:
    • its top quarter puts the page above it, as before;
    • its bottom quarter puts it below it, with a blue line under the row;
    • the middle puts it into it.
  • Below an open page whose sub-pages are showing is still into it, because what's just below is its first sub-page.
  • reorderPages puts the page after the target for "below".

Test (e2e/sidebar.spec.ts), using the browser's own drag events:

  • a page dropped on the lower edge of the last top-level page goes last;
  • one dropped below the last sub-page of an open page becomes that page's last sub-page;
  • the middle of a row still puts a page into it.

It fails on main, where the page went into the last page.

🤖 Generated with Claude Code

A row only took a page above it (its top fifth) or into it (the rest), so nothing could go after
the last page. Now its bottom quarter puts the page below it, with a line under the row; an open
page with pages showing in it still takes it in.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant