Skip to content

Links to private pages: a lock, and a note while choosing one, on pages others read - #218

Merged
LoopyDev merged 2 commits into
mainfrom
feat/private-page-links
Nov 14, 2026
Merged

LoopyDev merged 2 commits into
mainfrom
feat/private-page-links

Conversation

@LoopyDev

Copy link
Copy Markdown
Owner

Mentions of, and links to, a private page are allowed on a page others can read: they see "Private page" and can't open it. Its author sees the title, though, so it's easy to forget that. Now the author is told.

The lock

  • A padlock after a mention's title, or after words linked to a private page, on a page that isn't private.
  • It explains on hover: "Only you can open this page; others see 'Private page'".
  • The linked words' padlock comes from a decoration (tiptap/linkEditor.js). It's worked out again when the text changes, or when the page list does (a page made private or shared, or the list loaded after the page).

The note

  • "Only you can open this page; others will see 'Private page'" shows:
    • under the @, [[ and (/ lists while a private page is highlighted (and those lists put a padlock beside private pages);
    • in the link editor once one is picked.
  • Neither the padlock nor the note shows on a private page, which no one else reads.

Also: a mention is now in the text's own colour, not link-blue and underlined. The editor's link style was more specific than the mention's.

Tests (e2e/private-page-links.spec.ts):

  • on a public page, the note in the @ list and in the link editor, the padlock on the mention and on the linked words, and the mention's colour;
  • on a private page, none of them;
  • a page made private later gets its padlock without anyone editing.

🤖 Generated with Claude Code

LoopyDev and others added 2 commits November 14, 2026 10:32
…es others read

A mention of, or link to, a private page on a page others can read shows a lock (they see
"Private page" and can't open it); the @, [[ and "(/" lists and the link editor say "Only you
can open this page" for one. The locks follow pages made private or shared. Mentions are in the
text's own colour (the editor's link colour won over it).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…changes

Every change to the page list (anyone's edit) redrew the page for the locks, and a redraw as the
browser moved the cursor (End) put it back: a phone test's typing landed mid-line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@LoopyDev
LoopyDev merged commit 60253c6 into main Nov 14, 2026
7 checks passed
@LoopyDev
LoopyDev deleted the feat/private-page-links branch November 14, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant