Repository navigation
Links to private pages: a lock, and a note while choosing one, on pages others read - #218
Merged
Merged
Conversation
…es others read A mention of, or link to, a private page on a page others can read shows a lock (they see "Private page" and can't open it); the @, [[ and "(/" lists and the link editor say "Only you can open this page" for one. The locks follow pages made private or shared. Mentions are in the text's own colour (the editor's link colour won over it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…changes Every change to the page list (anyone's edit) redrew the page for the locks, and a redraw as the browser moved the cursor (End) put it back: a phone test's typing landed mid-line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mentions of, and links to, a private page are allowed on a page others can read: they see "Private page" and can't open it. Its author sees the title, though, so it's easy to forget that. Now the author is told.
The lock
tiptap/linkEditor.js). It's worked out again when the text changes, or when the page list does (a page made private or shared, or the list loaded after the page).The note
(/lists while a private page is highlighted (and those lists put a padlock beside private pages);Also: a mention is now in the text's own colour, not link-blue and underlined. The editor's link style was more specific than the mention's.
Tests (
e2e/private-page-links.spec.ts):🤖 Generated with Claude Code