Repository navigation
Improve COM container compatibility - #77
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pmeems
left a comment
There was a problem hiding this comment.
Reviewed phase 6 after merging development. The build, registration, status-flag, type-info and persistence defects found during review were fixed in the branch; no unresolved findings remain. Local Debug x64 CMake and MSBuild builds and native tests passed, with three CTest cases skipped. Compile-option parity and per-user registration in an isolated registry passed. Interactive registered hosting and other CI configurations remain unverified locally; CI is rerunning. Final decision is with the human reviewer.
There was a problem hiding this comment.
🟡 Changes recommended
The new enum in DllInstallScope.h omits the explicit underlying type required by the coding standards and should declare : int.
1 open issue
What changed in this PR
Improves the ActiveX wrapper’s compatibility with COM containers through class information, persistence, and consistent registration metadata, without changing the native core.
Changes:
- Adds class/type information and rendering-preference persistence, including legacy empty-stream support.
- Aligns registered and registration-free OLE status flags and clarifies
DllInstallregistration scope. - Adds compatibility tests and documents registration and the early-bound GDAL contract.
Builds and tests were not run during this review.
| File | Description |
|---|---|
tests/MapWinGIS.ActiveX.Tests/Verify-ActiveXActivation.ps1 |
Checks registered OLE status flags. |
tests/MapWinGIS.ActiveX.Tests/ActiveXActivationTests.cpp |
Adds type-info, persistence, and registration-scope tests. |
src/MapWinGIS.ActiveX/MapWinGISControl.rgs |
Registers content-aspect OLE status flags. |
src/MapWinGIS.ActiveX/MapWinGISControl.h |
Exposes class information and property-bag persistence. |
src/MapWinGIS.ActiveX/MapWinGISControl.cpp |
Handles legacy streams and tracks preference changes as dirty. |
src/MapWinGIS.ActiveX/MapWinGIS.ActiveX.vcxproj |
Includes the registration-scope helper in MSBuild. |
src/MapWinGIS.ActiveX/MapWinGIS.ActiveX.idl |
Documents the early-bound GDAL contract; no interface changes. |
src/MapWinGIS.ActiveX/DllInstallScope.h |
Parses machine-wide and per-user registration arguments. |
src/MapWinGIS.ActiveX/CMakeLists.txt |
Includes the registration-scope helper in CMake. |
src/MapWinGIS.ActiveX/ActiveXModule.cpp |
Applies explicit registration scope in DllInstall. |
samples/CSharp/ActiveXTestHost/app.manifest |
Mirrors OLE status flags for registration-free hosting. |
docs/BUILDING.md |
Explains registration commands and OLE flags. |
docs/ARCHITECTURE.md |
Documents GDAL binding and persistence behavior. |
.github/plans/development-review-fix-plan-20261113.md |
Records phase completion and reported validation. |
.ai/memory/lessons/lessons.md |
Records an ATL registry-script parsing lesson. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Summary
IProvideClassInfo2, property-bag persistence, and persistRenderingBackendPreferencethrough the ATL property map.MiscStatusflags and mirror them in the registration-free C# host manifest.SAFEARRAY(BSTR)/hypercontract is early-bound only.DllInstalltreat null/empty arguments as machine-wide, acceptusercase-insensitively, and cover the parser without touching the registry.Validation
Builds and tests were not run: this session has GitHub repository access but no local Windows/Visual Studio worktree. CI should validate ATL compilation, COM persistence and registration-free activation.