Skip to content

Improve COM container compatibility - #77

Merged
pmeems merged 20 commits into
developmentfrom
fix/com-container-compatibility
Nov 15, 2026
Merged

pmeems merged 20 commits into
developmentfrom
fix/com-container-compatibility

Conversation

@Victor-MW-cl

Copy link
Copy Markdown

Summary

  • Add IProvideClassInfo2, property-bag persistence, and persist RenderingBackendPreference through the ATL property map.
  • Register the ActiveX MiscStatus flags and mirror them in the registration-free C# host manifest.
  • Load GDAL interface type information from the OCX and document that its SAFEARRAY(BSTR)/hyper contract is early-bound only.
  • Make DllInstall treat null/empty arguments as machine-wide, accept user case-insensitively, and cover the parser without touching the registry.
  • Add COM class-info, type-info, stream/property-bag persistence, and registration-scope tests.

Validation

Builds and tests were not run: this session has GitHub repository access but no local Windows/Visual Studio worktree. CI should validate ATL compilation, COM persistence and registration-free activation.

@pmeems pmeems left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed phase 6 after merging development. The build, registration, status-flag, type-info and persistence defects found during review were fixed in the branch; no unresolved findings remain. Local Debug x64 CMake and MSBuild builds and native tests passed, with three CTest cases skipped. Compile-option parity and per-user registration in an isolated registry passed. Interactive registered hosting and other CI configurations remain unverified locally; CI is rerunning. Final decision is with the human reviewer.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new enum in DllInstallScope.h omits the explicit underlying type required by the coding standards and should declare : int.

1 open issue
What changed in this PR

Improves the ActiveX wrapper’s compatibility with COM containers through class information, persistence, and consistent registration metadata, without changing the native core.

Changes:

  • Adds class/type information and rendering-preference persistence, including legacy empty-stream support.
  • Aligns registered and registration-free OLE status flags and clarifies DllInstall registration scope.
  • Adds compatibility tests and documents registration and the early-bound GDAL contract.

Builds and tests were not run during this review.

File Description
tests/​MapWinGIS.ActiveX.Tests/​Verify-ActiveXActivation.ps1 Checks registered OLE status flags.
tests/​MapWinGIS.ActiveX.Tests/​ActiveXActivationTests.cpp Adds type-info, persistence, and registration-scope tests.
src/​MapWinGIS.ActiveX/​MapWinGISControl.rgs Registers content-aspect OLE status flags.
src/​MapWinGIS.ActiveX/​MapWinGISControl.h Exposes class information and property-bag persistence.
src/​MapWinGIS.ActiveX/​MapWinGISControl.cpp Handles legacy streams and tracks preference changes as dirty.
src/​MapWinGIS.ActiveX/​MapWinGIS.ActiveX.vcxproj Includes the registration-scope helper in MSBuild.
src/​MapWinGIS.ActiveX/​MapWinGIS.ActiveX.idl Documents the early-bound GDAL contract; no interface changes.
src/​MapWinGIS.ActiveX/​DllInstallScope.h Parses machine-wide and per-user registration arguments.
src/​MapWinGIS.ActiveX/​CMakeLists.txt Includes the registration-scope helper in CMake.
src/​MapWinGIS.ActiveX/​ActiveXModule.cpp Applies explicit registration scope in DllInstall.
samples/​CSharp/​ActiveXTestHost/​app.manifest Mirrors OLE status flags for registration-free hosting.
docs/​BUILDING.md Explains registration commands and OLE flags.
docs/​ARCHITECTURE.md Documents GDAL binding and persistence behavior.
.github/​plans/​development-review-fix-plan-20261113.md Records phase completion and reported validation.
.ai/​memory/​lessons/​lessons.md Records an ATL registry-script parsing lesson.

Review effort: Balanced

Comment thread src/MapWinGIS.ActiveX/DllInstallScope.h Resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@pmeems
pmeems enabled auto-merge (squash) November 15, 2026 12:58
@pmeems
pmeems merged commit 6658a52 into development Nov 15, 2026
6 checks passed
@pmeems
pmeems deleted the fix/com-container-compatibility branch November 15, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants