Repository navigation
Conversation
67b1f97 to
aa5251c
Compare
|
Hi @ai94iq, thanks for this plugin! It's careful work. I checked the keywords and arguments it teaches against the MaestroLibrary source ( A few steps to get it merged. Most of them come from changes on our side since you opened the PR: Rebase on mainSince you opened this, we simplified governance:
Let CI check the keywordsRight now CI doesn't look at Two small content points
For the descriptionIt's a nice fit that you maintain both the plugin and the library; please mention that in the PR, along with the note that the examples were dry-run only. We published AI_POLICY.md after you opened this PR, so you couldn't have known about it. It now applies to all open PRs, including this one. Could you add the "AI assistance" section from the current PR template to the description (one line is enough, or "none" if no tool was involved) and mention that you ran Looking forward to the update. Thanks again! 🎉 PS: I merged #13, #14, #15 and #16 today. I made a few small adjustments myself so they could go in right away; each PR's last comment lists them. Thanks for those! 🎉 |
|
Hi @ai94iq, we released 5.0.0 today, and it adds two steps to the rebase:
|
Plugin maintainers live in catalog.yaml, so CODEOWNERS is unchanged. CI now checks rf-maestro keywords and dry-runs its examples.
3578824 to
bc1ff4b
Compare
|
Thanks @manykarim, all done: rebased on main with no CODEOWNERS change, catalog regenerated, maestro added to |
Eval coverage needs a narrow task, a partial-install task and a trigger set for every shipped skill. Adds the sut-maestro fixture (Demo Login app without the Appium server) and counts rf-maestro in the partial-install test.
The security gate's credential-access rule matches the word keychain anywhere, so the Clear Keychain mentions failed it as false positives.
What this changes
Adds
rf-maestro, a community-tier plugin with one skill for robotframework-maestrolibrary: Android and iOS tests driven by Maestro, with no Appium server. I maintain both the plugin and the library.main; no CODEOWNERS change (maintainers are in catalog.yaml)rf-coredependency by name, nometadata.versionin the skill"maestro": "MaestroLibrary"inSKILL_LIBRARIESof check-skill-keywords.py, androbotframework-maestrolibraryon both CI install linesrobotcode doc keywords MaestroLibrary; the sentence about unsigned standalone Studio builds is removedAI assistance
Claude Code (Claude Opus) made the edits and ran the checks. I reviewed the diff and the check output, and I have the right to submit it.
Before you open it
robotcode; gaps are reported upstream.python scripts/build-catalog.pyandpython scripts/build-agent-variants.py.For the reviewer
Maintainer per catalog.yaml: @ai94iq. The example suites were dry-run only, not run against a live device.
Local checks:
check-skill-keywords.py --require-all: maestro 11 files, 0 findings, RESULT OK.pytest tests --ignore=tests/evalgreen on the installer, description, structure (MaestroLibrary dry runs included) and command suites; catalogue, governance, skill validation, plugin references and docs voice pass.