You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix conditional graph lifetime tests to use supported nodes - #3469
Two graph lifetime tests populate conditional bodies with host callback nodes, which violate CUDA's documented body-graph requirements. A development driver rejects this setup with CUDA_ERROR_INVALID_VALUE, so all eight parameterized cases fail before reaching their lifetime assertions.
Use memset nodes with explicit sentinel owners to check attachment retention and release, and empty nodes to check graph and node-handle invalidation. The tests continue to cover if, if_else, while, and switch. The device allocation stays alive until body-node destruction and deferred owner cleanup complete.
Validation
Tested locally on Ubuntu 24.04 x86_64 with Python 3.12:
Before the change: all eight affected cases reproduce the setup failure.
After the change: all eight pass without skips.
Complete graph test suite: 551 passed, 24 skipped.
Full pre-commit: all hooks pass except lychee, which reports three existing GitHub 404 links in release notes.
Reviewing files that changed from the base of the PR and between 9082ea9 and 94f2721.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Summary
Summary by CodeRabbit
Tests
Updated coverage for attachment lifetimes in conditional branches, including release after destroying the parent node.
Adjusted branch-handle invalidation tests to use empty nodes.
The conditional-branch lifetime tests now use sentinel owners retained by branch memset attachments and empty branch nodes. They verify that destroying the parent ConditionalNode releases the owners and invalidates the branch nodes.
The attachment-release test checks that sentinel owners remain alive before parent destruction and are released afterward. The invalidation test uses empty branch nodes and retains its invalidation assertions.
Suggested labels:test
Suggested reviewers:andy-jost
Change: Other
Merge Risk: Minimal · previous review 9082e
This updates two conditional graph lifetime tests to use supported node types. It does not change production behavior, and no merge-blocking risk was found.
Security architecture risk: Minimal · up to 9082e
The change replaces unsupported test fixtures without changing production graph behavior or security boundaries. No introduced or worsened architecture risk was identified.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.
)
* Fix conditional graph lifetime tests to use supported nodes
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
* ci: require manual copy-pr-bot approval
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
---------
Signed-off-by: Ralf W. Grosse-Kunstleve <rgrossekunst@nvidia.com>
Co-authored-by: Andy Jost <ajost@nvidia.com>
(cherry picked from commit b80866b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuda.coreEverything related to the cuda.core moduleP0High priority - Must do!to-be-backportedTrigger the bot to raise a backport PR upon merge
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
— codex on behalf of Ralf —
Description
Two graph lifetime tests populate conditional bodies with host callback nodes, which violate CUDA's documented body-graph requirements. A development driver rejects this setup with
CUDA_ERROR_INVALID_VALUE, so all eight parameterized cases fail before reaching their lifetime assertions.Use memset nodes with explicit sentinel owners to check attachment retention and release, and empty nodes to check graph and node-handle invalidation. The tests continue to cover
if,if_else,while, andswitch. The device allocation stays alive until body-node destruction and deferred owner cleanup complete.Validation
Tested locally on Ubuntu 24.04 x86_64 with Python 3.12:
Checklist