Skip to content

Fail cuvs-lucene CI tests when a module runs no tests - #3038

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
imotov:lucene-fail-if-no-tests
Nov 10, 2026
Merged

rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
imotov:lucene-fail-if-no-tests

Conversation

@imotov

@imotov imotov commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

The cuvs-lucene test jobs run tests from target/ directories restored from the build job. If a module's restored directory has no test classes, surefire reports it as passed without running anything. Pass -DfailIfNoTests=true so such a module fails the job instead.

Relates to #2702

The cuvs-lucene test jobs run tests from target/ directories restored from the build job. If a module's restored directory has no test classes, surefire reports it as passed without running anything. Pass -DfailIfNoTests=true so such a module fails the job instead.

Relates to NVIDIA#2702
@imotov imotov self-assigned this Nov 10, 2026
@imotov imotov added improvement Improves an existing functionality non-breaking Introduces a non-breaking change Lucene labels Nov 10, 2026
@copy-pr-bot

copy-pr-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@imotov

imotov commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 6b6328b

@imotov
imotov marked this pull request as ready for review November 10, 2026 22:29
@imotov
imotov requested a review from a team as a code owner November 10, 2026 22:29
@imotov
imotov requested a review from gforsyth November 10, 2026 22:29
@coderabbitai

coderabbitai Bot commented Nov 10, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Tests
    • Test runs now fail when a module contains no tests, rather than passing without executing any.

The Lucene Maven test invocation now includes -DfailIfNoTests=true. The existing --fail-at-end and -Dskip.compile=true options remain.

Changes: Lucene test execution

Layer / File(s) Summary
Maven test invocation
ci/test_lucene.sh
The Maven test arguments add -DfailIfNoTests=true. The existing --fail-at-end and -Dskip.compile=true options remain.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

  • NVIDIA/cuvs#2867: Changes the same script’s restored-module test flow and Maven failure handling.
  • NVIDIA/cuvs#3033: Adds a Lucene test that could otherwise be skipped when no test classes are found.
  • NVIDIA/cuvs#2887: Updates the Surefire plugin used with the new Maven option.

Suggested labels: bug

Merge Risk: Minimal · up to 6b632

The change makes missing test classes fail the Lucene CI job as intended. No merge-blocking risk was identified.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly identifies the change: failing cuvs-lucene CI tests when a module runs no tests.
Description check Passed The description explains why restored target directories can cause tests to be skipped and how the change makes the job fail in that case.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: NVIDIA/cuvs
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 4b6af58
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: fdc375c2-e5b9-4023-bc0f-4b477b18422c
Commits

Reviewing files that changed from the base of the PR and between 4b6af58 and 6b6328b.

Files selected for processing: 1

  • ci/test_lucene.sh

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@jameslamb
jameslamb removed the request for review from gforsyth November 10, 2026 23:06
@imotov

imotov commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 1e9a10c into NVIDIA:main Nov 10, 2026
143 of 145 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in Unstructured Data Processing Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality Lucene non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants