Skip to content

Search lib64 for CMake packages installed by wheels - #3091

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
bdice:wheel-lib64-paths
Nov 20, 2026
Merged

rapids-bot[bot] merged 2 commits into
NVIDIA:mainfrom
bdice:wheel-lib64-paths

Conversation

@bdice

@bdice bdice commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Enables FIND_LIBRARY_USE_LIB64_PATHS before find_package in the Python CMake projects that were missing it.

CMake disables FIND_LIBRARY_USE_LIB64_PATHS on Debian-derived systems, and RAPIDS wheels install their CMake configs under lib64/cmake. Without it, building a Python package from source on Ubuntu against an installed library wheel fails to find the library, or builds it again from source. CI doesn't hit this because wheels are built on Rocky Linux.

Part of rapidsai/build-planning#325.

@bdice bdice added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Nov 19, 2026
@copy-pr-bot

copy-pr-bot Bot commented Nov 19, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@bdice
bdice marked this pull request as ready for review November 19, 2026 22:54
@bdice
bdice requested a review from a team as a code owner November 19, 2026 22:54
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

  • Source mode: Auto
  • Repository: NVIDIA/cuvs
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: a08af82
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 0386ce0e-1a34-4553-bd25-82219f164516
Commits

Reviewing files that changed from the base of the PR and between b21158c and 155e766.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Build configuration now includes lib64 directories when searching for libraries. This may help builds locate installed libraries on systems that use those directories. No changes to application features or behavior are included in this update.

The CMake configuration enables the global FIND_LIBRARY_USE_LIB64_PATHS property. A comment describes library lookup from RAPIDS wheels in site-packages.

Changes: CMake Library Lookup

Layer / File(s) Summary
Enable lib64 library lookup
c/CMakeLists.txt
Sets FIND_LIBRARY_USE_LIB64_PATHS to TRUE and adds a comment about library lookup from RAPIDS wheels in site-packages.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: robertmaynard, kylefromnvidia

Merge Risk: Minimal · previous review b2115

This change lets CMake search lib64 directories when building the C library from source on Debian-derived systems, so it can find packages installed from RAPIDS wheels. It is a small configuration change with a limited blast radius and no identified merge risk.

Architecture risk: Low · up to b2115

The change affects 1 system.

Changed systems: c

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — c (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in c/CMakeLists.txt: Adds a comment documenting library lookup from RAPIDS wheels in site-packages and sets the global FIND_LIBRARY_USE_LIB64_PATHS property to TRUE.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the core change: CMake will search lib64 for CMake packages installed by wheels. The raw summary confirms the change enables FIND_LIBRARY_USE_LIB64_PATHS in c/CMakeLists.txt, which mat…
Description check Passed The description states the change: it enables FIND_LIBRARY_USE_LIB64_PATHS before find_package in Python CMake projects. It also gives the reason, which is that CMake disables this setting on Debian-d…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the core change: CMake will search lib64 for CMake packages installed by wheels. The raw summary confirms the change enables FIND_LIBRARY_USE_LIB64_PATHS in c/CMakeLists.txt, which matches the title. The title is specific and concise, so it passes.

Full details: Description check

Explanation

The description states the change: it enables FIND_LIBRARY_USE_LIB64_PATHS before find_package in Python CMake projects. It also gives the reason, which is that CMake disables this setting on Debian-derived systems while RAPIDS wheels install configs under lib64/cmake. The description is on-topic and detailed, so it passes.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: NVIDIA/cuvs
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 9606988
  • Layers: Repository YAML
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: cbe84c17-770c-43af-bf97-674bdb6408a1
Commits

Reviewing files that changed from the base of the PR and between 9606988 and b21158c.

Files selected for processing: 1

  • c/CMakeLists.txt

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.

@bdice

bdice commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 0897086 into NVIDIA:main Nov 20, 2026
113 of 114 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in Unstructured Data Processing Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants