You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Search lib64 for CMake packages installed by wheels - #3091
Enables FIND_LIBRARY_USE_LIB64_PATHS before find_package in the Python CMake projects that were missing it.
CMake disables FIND_LIBRARY_USE_LIB64_PATHS on Debian-derived systems, and RAPIDS wheels install their CMake configs under lib64/cmake. Without it, building a Python package from source on Ubuntu against an installed library wheel fails to find the library, or builds it again from source. CI doesn't hit this because wheels are built on Rocky Linux.
Reviewing files that changed from the base of the PR and between b21158c and 155e766.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Summary
Summary by CodeRabbit
Chores
Build configuration now includes lib64 directories when searching for libraries. This may help builds locate installed libraries on systems that use those directories. No changes to application features or behavior are included in this update.
The CMake configuration enables the global FIND_LIBRARY_USE_LIB64_PATHS property. A comment describes library lookup from RAPIDS wheels in site-packages.
Changes: CMake Library Lookup
Layer / File(s)
Summary
Enable lib64 library lookup c/CMakeLists.txt
Sets FIND_LIBRARY_USE_LIB64_PATHS to TRUE and adds a comment about library lookup from RAPIDS wheels in site-packages.
This change lets CMake search lib64 directories when building the C library from source on Debian-derived systems, so it can find packages installed from RAPIDS wheels. It is a small configuration change with a limited blast radius and no identified merge risk.
Architecture risk: Low · up to b2115
The change affects 1 system.
Changed systems:c
Architecture concerns
No architecture-level concerns identified.
Review details
Systems and components
observed — c (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
observed — Modified behavior in c/CMakeLists.txt: Adds a comment documenting library lookup from RAPIDS wheels in site-packages and sets the global FIND_LIBRARY_USE_LIB64_PATHS property to TRUE.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the core change: CMake will search lib64 for CMake packages installed by wheels. The raw summary confirms the change enables FIND_LIBRARY_USE_LIB64_PATHS in c/CMakeLists.txt, which mat…
Description check
The description states the change: it enables FIND_LIBRARY_USE_LIB64_PATHS before find_package in Python CMake projects. It also gives the reason, which is that CMake disables this setting on Debian-d…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the core change: CMake will search lib64 for CMake packages installed by wheels. The raw summary confirms the change enables FIND_LIBRARY_USE_LIB64_PATHS in c/CMakeLists.txt, which matches the title. The title is specific and concise, so it passes.
Full details: Description check
Explanation
The description states the change: it enables FIND_LIBRARY_USE_LIB64_PATHS before find_package in Python CMake projects. It also gives the reason, which is that CMake disables this setting on Debian-derived systems while RAPIDS wheels install configs under lib64/cmake. The description is on-topic and detailed, so it passes.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Reviewing files that changed from the base of the PR and between 9606988 and b21158c.
Files selected for processing: 1
c/CMakeLists.txt
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables
FIND_LIBRARY_USE_LIB64_PATHSbeforefind_packagein the Python CMake projects that were missing it.CMake disables
FIND_LIBRARY_USE_LIB64_PATHSon Debian-derived systems, and RAPIDS wheels install their CMake configs underlib64/cmake. Without it, building a Python package from source on Ubuntu against an installed library wheel fails to find the library, or builds it again from source. CI doesn't hit this because wheels are built on Rocky Linux.Part of rapidsai/build-planning#325.