Repository navigation
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,214 @@ | |||
| { | |||
There was a problem hiding this comment.
[nit] Not a strong take here, I'm wondering if it might be good to make the bullet point here match the title below.
Reply via ReviewNB
| @@ -0,0 +1,214 @@ | |||
| { | |||
There was a problem hiding this comment.
Do we have anything we can link to here re: setting the velocity restart flag to avoid crashes?
Reply via ReviewNB
| @@ -0,0 +1,214 @@ | |||
| { | |||
There was a problem hiding this comment.
Just FYI - I think the solvent padding description is broken, it's something we should look into at some point.
Reply via ReviewNB
| @@ -0,0 +1,214 @@ | |||
| { | |||
There was a problem hiding this comment.
Would be good to have a section that just talks about how to set the force fields for your model.
Reply via ReviewNB
IAlibay
left a comment
There was a problem hiding this comment.
Looks good, a few small things - going to merge mostly on the velocity resetting thing for the virtual sites.
Starting to address OpenFreeEnergy/openfe#2314 and OpenFreeEnergy/openfe#869