Skip to content

Add a customising the model how to guide - #358

Open
jthorton wants to merge 3 commits into
mainfrom
model_building
Open

jthorton wants to merge 3 commits into
mainfrom
model_building

Conversation

@jthorton

@jthorton jthorton commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

Colab 👈 Launch a Colab session on branch model_building

@jthorton jthorton self-assigned this Nov 17, 2026
@@ -0,0 +1,214 @@
{

@IAlibay IAlibay Nov 17, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Not a strong take here, I'm wondering if it might be good to make the bullet point here match the title below.


Reply via ReviewNB

@@ -0,0 +1,214 @@
{

@IAlibay IAlibay Nov 17, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have anything we can link to here re: setting the velocity restart flag to avoid crashes?


Reply via ReviewNB

@@ -0,0 +1,214 @@
{

@IAlibay IAlibay Nov 17, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI - I think the solvent padding description is broken, it's something we should look into at some point.


Reply via ReviewNB

@@ -0,0 +1,214 @@
{

@IAlibay IAlibay Nov 17, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a section that just talks about how to set the force fields for your model.


Reply via ReviewNB

@IAlibay IAlibay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few small things - going to merge mostly on the velocity resetting thing for the virtual sites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants