Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions API.IntegrationTests/AssemblyAttributes.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,14 @@ public sealed record CiSafeParallelLimit : IParallelLimit
{
public int Limit => Math.Max(Environment.ProcessorCount * 2, 8);
}

public static class ThreadPoolSetup
{
// Running tests block on the shared host's boot, which connects to Redis synchronously and needs a free thread
[Before(TestSession)]
public static void RaiseMinThreads()
{
ThreadPool.GetMinThreads(out var workerThreads, out var completionPortThreads);
ThreadPool.SetMinThreads(Math.Max(workerThreads, new CiSafeParallelLimit().Limit * 2), completionPortThreads);
}
}
2 changes: 1 addition & 1 deletion API.IntegrationTests/Docker/InMemoryDatabase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public PostgreSqlContainer Container
{
get
{
_container ??= new PostgreSqlBuilder(image: "postgres:latest")
_container ??= new PostgreSqlBuilder(image: "timescale/timescaledb:latest-pg18") // Community edition, the schema needs it
.WithNetwork(DockerNetwork.Instance)
.WithName($"tunit-postgresql-{Guid.CreateVersion7()}")
.WithDatabase("openshock")
Expand Down
87 changes: 87 additions & 0 deletions API.IntegrationTests/Helpers/ControlLogHelper.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
using Microsoft.EntityFrameworkCore;
using Microsoft.Extensions.DependencyInjection;
using Npgsql;
using OpenShock.Common.OpenShockDb;

namespace OpenShock.API.IntegrationTests.Helpers;

public static class ControlLogHelper
{
// Tests run in parallel against one database
private static readonly SemaphoreSlim RefreshLock = new(1, 1);

public static async Task<Guid> CreateShocker(WebApplicationFactory factory, Guid ownerId, string name)
{
var (deviceId, _) = await TestHelper.CreateDeviceInDb(factory, ownerId);

await using var scope = factory.Services.CreateAsyncScope();
var db = scope.ServiceProvider.GetRequiredService<OpenShockContext>();

var shockerId = Guid.CreateVersion7();
db.Shockers.Add(new Shocker
{
Id = shockerId,
Name = name,
Model = ShockerModelType.CaiXianlin,
RfId = 1234,
DeviceId = deviceId
});
await db.SaveChangesAsync();
return shockerId;
}

public static ShockerControlLog Log(Guid ownerId, Guid shockerId, Guid? controllerId, DateTime at,
byte intensity = 50, uint duration = 1000, ControlType type = ControlType.Shock, bool live = false,
byte? maxIntensity = null) => new()
{
Id = Guid.CreateVersion7(),
OwnerUserId = ownerId,
ShockerId = shockerId,
ControlledByUserId = controllerId,
Intensity = intensity,
MaxIntensity = maxIntensity ?? intensity,
Duration = duration,
Type = type,
CustomName = null,
LiveControl = live,
CreatedAt = at
};

public static async Task<int> Insert(WebApplicationFactory factory, params ShockerControlLog[] logs)
{
await using var scope = factory.Services.CreateAsyncScope();
return await scope.ServiceProvider.GetRequiredService<OpenShockContext>().InsertControlLogsAsync(logs);
}

/// <summary>
/// Logs older than an hour only show up in <c>control_stats</c> once refreshed.
/// </summary>
public static async Task RefreshControlStats(WebApplicationFactory factory)
{
await RefreshLock.WaitAsync();
try
{
await using var scope = factory.Services.CreateAsyncScope();
var db = scope.ServiceProvider.GetRequiredService<OpenShockContext>();

// The refresh policy job may hold the same range, TimescaleDB fails instead of waiting
for (var attempt = 1;; attempt++)
{
try
{
await db.Database.ExecuteSqlRawAsync(
"CALL refresh_continuous_aggregate('control_stats', NULL, now() - INTERVAL '1 hour')");
return;
}
catch (PostgresException e) when (e.SqlState == PostgresErrorCodes.LockNotAvailable && attempt < 10)
{
await Task.Delay(TimeSpan.FromMilliseconds(200 * attempt));
}
}
}
finally
{
RefreshLock.Release();
}
}
}
99 changes: 37 additions & 62 deletions API.IntegrationTests/Tests/ControlStatChangesTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
using OpenShock.Common.OpenShockDb;
using OpenShock.Common.Services.AutomationTokens;
using OpenShock.Common.Utils;
using static OpenShock.API.IntegrationTests.Helpers.ControlLogHelper;

namespace OpenShock.API.IntegrationTests.Tests;

Expand Down Expand Up @@ -37,12 +38,16 @@ public async Task InitialSync_ReportsEveryRequestedUser_WithReceivedAndGivenTota
var controller = await CreateUser("chgctrl");
var idle = await CreateUser("chgidle");
var notRequested = await CreateUser("chgother");
var shockerId = await CreateShocker(owner, "Changes");
var shockerId = await CreateShocker(WebApplicationFactory, owner, "Changes");
var at = new DateTime(2026, 3, 1, 12, 0, 0, DateTimeKind.Utc);

await Upsert(
Delta(owner, shockerId, controller, at, count: 2, intensity: 40),
Delta(owner, shockerId, notRequested, at, count: 7));
await Insert(WebApplicationFactory,
[
Log(owner, shockerId, controller, at, intensity: 40),
Log(owner, shockerId, controller, at, intensity: 40),
.. Enumerable.Range(0, 7).Select(_ => Log(owner, shockerId, notRequested, at))
]);
await RefreshControlStats(WebApplicationFactory);

using var client = await CreateTokenClient([AutomationTokenType.ControlStatsRead]);
using var doc = await Post(client, new { userIds = new[] { owner, controller, idle } });
Expand All @@ -69,13 +74,16 @@ public async Task Since_OnlyReportsUsersWithRecentActivity()
{
var owner = await CreateUser("chgsince");
var quiet = await CreateUser("chgquiet");
var shockerId = await CreateShocker(owner, "Since");
var quietShockerId = await CreateShocker(quiet, "Quiet");
var shockerId = await CreateShocker(WebApplicationFactory, owner, "Since");
var quietShockerId = await CreateShocker(WebApplicationFactory, quiet, "Quiet");

// Old activity only, outside of any lookback
var old = new DateTime(2026, 1, 1, 12, 0, 0, DateTimeKind.Utc);
await Upsert(Delta(owner, shockerId, owner, old, count: 3), Delta(quiet, quietShockerId, quiet, old, count: 1));
await Insert(WebApplicationFactory,
Log(owner, shockerId, owner, old), Log(owner, shockerId, owner, old), Log(owner, shockerId, owner, old),
Log(quiet, quietShockerId, quiet, old));
await Backdate(owner, quiet);
await RefreshControlStats(WebApplicationFactory);

using var client = await CreateTokenClient([AutomationTokenType.ControlStatsRead]);
var userIds = new[] { owner, quiet };
Expand All @@ -87,7 +95,7 @@ public async Task Since_OnlyReportsUsersWithRecentActivity()
using (var unchanged = await Post(client, new { since = cursor, userIds }))
await Assert.That(unchanged.RootElement.GetProperty("users").GetArrayLength()).IsEqualTo(0);

await Upsert(Delta(owner, shockerId, owner, DateTime.UtcNow, count: 1));
await Insert(WebApplicationFactory, Log(owner, shockerId, owner, DateTime.UtcNow));

using var changed = await Post(client, new { since = cursor, userIds });
var user = changed.RootElement.GetProperty("users").EnumerateArray().Single();
Expand All @@ -101,8 +109,10 @@ public async Task Since_AtMinValue_ReportsUsersWithAnyActivity()
{
var owner = await CreateUser("chgmin");
var idle = await CreateUser("chgminidle");
var shockerId = await CreateShocker(owner, "MinValue");
await Upsert(Delta(owner, shockerId, owner, new DateTime(2026, 1, 1, 12, 0, 0, DateTimeKind.Utc), count: 2));
var shockerId = await CreateShocker(WebApplicationFactory, owner, "MinValue");
var at = new DateTime(2026, 1, 1, 12, 0, 0, DateTimeKind.Utc);
await Insert(WebApplicationFactory, Log(owner, shockerId, owner, at), Log(owner, shockerId, owner, at));
await RefreshControlStats(WebApplicationFactory);

using var client = await CreateTokenClient([AutomationTokenType.ControlStatsRead]);

Expand All @@ -118,10 +128,10 @@ public async Task Since_AtMinValue_ReportsUsersWithAnyActivity()
}

[Test]
public async Task Since_ReportsLateWritesIntoOldBuckets()
public async Task Since_ReportsLateWrites()
{
var owner = await CreateUser("chglate");
var shockerId = await CreateShocker(owner, "Late");
var shockerId = await CreateShocker(WebApplicationFactory, owner, "Late");

using var client = await CreateTokenClient([AutomationTokenType.ControlStatsRead]);
var userIds = new[] { owner };
Expand All @@ -131,65 +141,50 @@ public async Task Since_ReportsLateWritesIntoOldBuckets()
cursor = initial.RootElement.GetProperty("cursor").GetDateTime();

// Live control from hours ago that only reached the database now, e.g. after an outage
await Upsert(Delta(owner, shockerId, owner, DateTime.UtcNow.AddHours(-3), count: 1));
await Insert(WebApplicationFactory, Log(owner, shockerId, owner, DateTime.UtcNow.AddHours(-3), live: true));

using var changed = await Post(client, new { since = cursor, userIds });
var user = changed.RootElement.GetProperty("users").EnumerateArray().Single();
await Assert.That(user.GetProperty("userId").GetGuid()).IsEqualTo(owner);
}

[Test]
public async Task Since_ReportsControllersWhoseStatsWereDeleted()
public async Task DeletedOwners_AreLeftOutOfGivenTotals()
{
var owner = await CreateUser("chgdelown");
var controller = await CreateUser("chgdelctl");
var shockerId = await CreateShocker(owner, "Deleted");
await Upsert(Delta(owner, shockerId, controller, new DateTime(2026, 1, 1, 12, 0, 0, DateTimeKind.Utc), count: 4));
await Backdate(owner);
var shockerId = await CreateShocker(WebApplicationFactory, owner, "Deleted");
await Insert(WebApplicationFactory,
Log(owner, shockerId, controller, new DateTime(2026, 1, 1, 12, 0, 0, DateTimeKind.Utc)));
await RefreshControlStats(WebApplicationFactory);

using var client = await CreateTokenClient([AutomationTokenType.ControlStatsRead]);
var userIds = new[] { controller };

DateTime cursor;
using (var initial = await Post(client, new { userIds }))
cursor = initial.RootElement.GetProperty("cursor").GetDateTime();

// As when the owner's account is deleted, which cascades onto their stats
await using (var scope = WebApplicationFactory.Services.CreateAsyncScope())
{
var db = scope.ServiceProvider.GetRequiredService<OpenShockContext>();
await db.ControlStats.Where(x => x.OwnerUserId == owner).ExecuteDeleteAsync();
await db.Users.Where(x => x.Id == owner).ExecuteDeleteAsync();
}

using var changed = await Post(client, new { since = cursor, userIds });
var user = changed.RootElement.GetProperty("users").EnumerateArray().Single();
using var client = await CreateTokenClient([AutomationTokenType.ControlStatsRead]);
using var doc = await Post(client, new { userIds = new[] { controller } });

var user = doc.RootElement.GetProperty("users").EnumerateArray().Single();
await Assert.That(user.GetProperty("userId").GetGuid()).IsEqualTo(controller);
await Assert.That(user.GetProperty("given").GetArrayLength()).IsEqualTo(0);
}

/// <summary>Moves the users' rows out of the change lookback, as if written long ago.</summary>
/// <summary>Moves the users' logs out of the change lookback, as if written long ago.</summary>
private async Task Backdate(params Guid[] ownerIds)
{
await using var scope = WebApplicationFactory.Services.CreateAsyncScope();
var db = scope.ServiceProvider.GetRequiredService<OpenShockContext>();
var longAgo = DateTime.UtcNow.AddDays(-1);
await db.ControlStats.Where(x => ownerIds.Contains(x.OwnerUserId))
.ExecuteUpdateAsync(x => x.SetProperty(y => y.UpdatedAt, longAgo));
await db.ShockerControlLogs.Where(x => ownerIds.Contains(x.OwnerUserId))
.ExecuteUpdateAsync(x => x.SetProperty(y => y.InsertedAt, longAgo));
}

private static ControlStatDelta Delta(Guid ownerId, Guid shockerId, Guid? controllerId, DateTime at, long count, byte intensity = 50) =>
new(ownerId, shockerId, controllerId, at, ControlType.Shock, Live: false, count, DurationMs: count * 1000,
IntensityMs: count * 1000 * intensity, intensity);

private static JsonElement SingleShock(JsonElement totals) => totals.EnumerateArray()
.Single(x => x.GetProperty("type").GetString() == "Shock" && !x.GetProperty("live").GetBoolean());

private async Task Upsert(params ControlStatDelta[] deltas)
{
await using var scope = WebApplicationFactory.Services.CreateAsyncScope();
await scope.ServiceProvider.GetRequiredService<OpenShockContext>().UpsertControlStatsAsync(deltas);
}

private static async Task<JsonDocument> Post(HttpClient client, object body)
{
var response = await client.PostAsync(Endpoint, TestHelper.JsonContent(body));
Expand Down Expand Up @@ -219,24 +214,4 @@ private async Task<HttpClient> CreateTokenClient(List<AutomationTokenType> types
client.DefaultRequestHeaders.Add(AuthConstants.AutomationTokenHeaderName, secret);
return client;
}

private async Task<Guid> CreateShocker(Guid ownerId, string name)
{
var (deviceId, _) = await TestHelper.CreateDeviceInDb(WebApplicationFactory, ownerId);

await using var scope = WebApplicationFactory.Services.CreateAsyncScope();
var db = scope.ServiceProvider.GetRequiredService<OpenShockContext>();

var shockerId = Guid.CreateVersion7();
db.Shockers.Add(new Shocker
{
Id = shockerId,
Name = name,
Model = ShockerModelType.CaiXianlin,
RfId = 1234,
DeviceId = deviceId
});
await db.SaveChangesAsync();
return shockerId;
}
}
}
Loading
Loading