Skip to content

Select correct url for MonAI logo file from project-monai repo in the load medical images notebook - #2089

Open
gsbhatia93 wants to merge 4 commits into
Project-MONAI:mainfrom
gsbhatia93:hotfix-main-logo-url
Open

gsbhatia93 wants to merge 4 commits into
Project-MONAI:mainfrom
gsbhatia93:hotfix-main-logo-url

Conversation

@gsbhatia93

@gsbhatia93 gsbhatia93 commented Nov 11, 2026 •

Copy link
Copy Markdown

Replace Monai.io with correct url and deletes the corrupted image that might already be loaded.

Fixes #2069

Description

Find the correct URL for monai.io main logo and replaced it with the defunct logo. An issue, I faced while loading the new files was that if the old corrupted file was present it would cause the cell to error out, so added an if clause to delete the old file and set the new one.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Tests

  1. Locally running the juypter notebook
  2. ./runner.sh -t module/load_medical_images.ipynb
Screenshot 2026-11-11 at 12 13 09 AM

Summary by CodeRabbit

  • Documentation
    • Updated the PNG example to download the MONAI logo from the project’s repository instead of the previous website.
    • The example now removes an existing temporary logo file before downloading the replacement.

…an if clause to delete corrupted file before setting the new ones.
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review.

Walkthrough

The PNG example now removes an existing temporary logo file before downloading the image from the MONAI GitHub repository instead of the previous monai.io URL.

Changes

Logo download

Layer / File(s) Summary
Replace the logo download source
modules/load_medical_images.ipynb
The download cell deletes the destination file if it exists, then downloads the logo from the MONAI GitHub documentation image URL.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: wyli

Merge Risk: Minimal · up to 5314f

The notebook now downloads the logo from a working MONAI repository URL and clears any stale file first. No merge-blocking risk was found.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Linked Issues check Inconclusive Issue #2069 asks to replace all defunct monai.io links in module/load_medical_images.ipynb with functional links. The AI-generated summary and PR description show one replacement: the logo URL now poi… Confirm that the reviewed head version of module/load_medical_images.ipynb contains no remaining 'monai.io' string. Use a search over the file, or a diff against the merge base that shows every changed line. If another monai.io link remains…
Passed Passed checks: 3 passed

Check name Status Explanation
Title check Passed The title names the main change: the notebook's MONAI logo URL is changed to the correct file in the Project-MONAI repo. It is specific and matches the summary and objectives. It is long (16 words), b…
Description check Passed The description covers the required parts of the template. It links the issue (Fixes #2069), explains the URL replacement and the if-clause that deletes the corrupted file, and checks every box in the…
Out of Scope Changes check Passed The reported change set is limited to module/load_medical_images.ipynb, which is the notebook named in issue #2069. The summary describes the change as a replaced logo URL and an added removal of an e…
Full details: Title check

Explanation

The title names the main change: the notebook's MONAI logo URL is changed to the correct file in the Project-MONAI repo. It is specific and matches the summary and objectives. It is long (16 words), but that does not make it unclear.

Full details: Description check

Explanation

The description covers the required parts of the template. It links the issue (Fixes #2069), explains the URL replacement and the if-clause that deletes the corrupted file, and checks every box in the Checks list. It also adds a Tests section with the local run and runner command. The Checks section is filled in, but the template's 'Fixes #' line has the issue number. The description omits a note on the Notebook runs automatically checkbox outcome; it is marked as done, so no gap there. Minor issues: the phrase 'defunct logo' is unclear (the old logo is defunct, not the new one), and the text has a typo 'juypter' and a path mismatch ('module/' vs. the template's 'modules/' is not an issue since the objectives use module/). These are non-critical.

Full details: Out of Scope Changes check

Explanation

The reported change set is limited to module/load_medical_images.ipynb, which is the notebook named in issue #2069. The summary describes the change as a replaced logo URL and an added removal of an existing MONAI-logo_color.png at the temporary path before download. Both changes directly support the fix for the defunct logo link. No unrelated files or features are reported in the summary.

Full details: Linked Issues check

Explanation

Issue #2069 asks to replace all defunct monai.io links in module/load_medical_images.ipynb with functional links. The AI-generated summary and PR description show one replacement: the logo URL now points to https://github.com/Project-MONAI/MONAI/blob/dev/docs/images/MONAI-logo-color.png. The summary reports +4/-1 changed lines, which fits one replaced link. The issue states that there are 'a few occurrences'. The reviewed head file is too large to read in full within the output limit, and the diff tool could not read the changed blobs. Therefore, the review cannot confirm that no other monai.io URL remains in the notebook. The removal of the stale local file before download is consistent with the stated fix, and the notebook test output shows a passing run. However, the test run does not prove that every link is functional.

Resolution

Confirm that the reviewed head version of module/load_medical_images.ipynb contains no remaining 'monai.io' string. Use a search over the file, or a diff against the merge base that shows every changed line. If another monai.io link remains, replace it with a functional URL and rerun the assessment.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1584c050-39c1-444a-a8fd-0d0ff5c9b3f1
Commits

Reviewing files that changed from the base of the PR and between 7beffcf and 5314ff0.

Files selected for processing: 1

  • modules/load_medical_images.ipynb

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@gsbhatia93 gsbhatia93 changed the title Select correct url for MonAI logo file from project-monai repo. Adds … Select correct url for MonAI logo file from project-monai repo in the load medical images notebook Nov 11, 2026
@gsbhatia93
gsbhatia93 marked this pull request as ready for review November 14, 2026 04:49

@ericspod ericspod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @gsbhatia93, this should be good to go once the tests pass.

@ericspod
ericspod enabled auto-merge (squash) November 16, 2026 16:05
@ericspod

Copy link
Copy Markdown
Member

@gsbhatia93 please do look at the DCO issue, we can merge after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

replace monai.io in the tutorials

2 participants