Repository navigation
4.x: Add Streamable collectInto operator - #8397
Merged
Merged
Conversation
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.786 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8397 +/- ##
============================================
- Coverage 98.64% 98.62% -0.02%
+ Complexity 7181 7180 -1
============================================
Files 826 826
Lines 51036 51038 +2
Branches 6944 6944
============================================
- Hits 50342 50335 -7
- Misses 473 482 +9
Partials 221 221 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
akarnokd
approved these changes
Nov 17, 2026
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #8299.
Summary
Add
Streamable.collectInto()withSingle<U>as its result type.The implementation checks
initialItemeagerly, then composes the existingcollect(() -> initialItem, collector)andlastOrError()operators. The collector receives the mutable container and each upstream item, matching the correspondingFlowable.collectIntocontract.Tests
Added
StreamableCollectIntoTestfor:initialItemandcollectorarguments.Test-first evidence: before the method was added, the new test class failed compilation with five missing-method errors.
The final focused run on Zulu JDK 26 covers
StreamableCollectIntoTest,StreamableCountTest, andCheckParamValidationNamingTest.checkStreamable: 10 tests, 0 failures/errors, 2 existing skips.checkstyleMainandcheckstyleTestpass. The full suite was not run for this focused addition.AI disclosure: Kimi Code assisted with API analysis, implementation, tests, local verification, and this PR description. The failing-before compilation result, generic type adjustments, final test results, and two-file diff were checked.