Repository navigation
zeroize: simplify bulk volatile writes - #1603
Merged
Merged
Conversation
tarcieri
force-pushed
the
zeroize/simplify-bulk-volatile-writes
branch
from
November 15, 2026 17:11
c37e5db to
2313d82
Compare
Followup to #1602 which migrates to safe slice-based fills for initialized values, bypassing the slice-pointer-slice round trip which was previously happening with the `volatile_set`-based API, which has subsequently been replaced with `volatile_zero` for the non-slice based use cases. This can potentially be DRYed out further with `zeroize_flat_type`, which I'd like to explore in a further followup.
tarcieri
force-pushed
the
zeroize/simplify-bulk-volatile-writes
branch
from
November 15, 2026 17:14
2313d82 to
76fefb5
Compare
tarcieri
added a commit
that referenced
this pull request
Nov 15, 2026
Adds an optimized byte slice zeroing function which uses a regular `fill` followed by `optimization_barrier` on platforms with stable `asm!` and falls back on the bulk volatile write implementation added in #1602 on other platforms. This approach should maintain the previous guarantees the purely volatile write-based approach provided on all platforms, while also providing the performance of the `optimization_barrier`-based approach on platforms with `asm!`. This function is public but also able to subsume the previous role of the internal `volatile_zero` function added in #1603.
tarcieri
added a commit
that referenced
this pull request
Nov 15, 2026
Adds an optimized byte slice zeroing function which uses a regular `fill` followed by `optimization_barrier` on platforms with stable `asm!` and falls back on the bulk volatile write implementation added in #1602 on other platforms. This approach should maintain the previous guarantees the purely volatile write-based approach provided on all platforms, while also providing the performance of the `optimization_barrier`-based approach on platforms with `asm!`. This function is public but also able to subsume the previous role of the internal `volatile_zero` function added in #1603.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #1602 which migrates to safe slice-based fills for initialized values, bypassing the slice-pointer-slice round trip which was previously happening with the
volatile_set-based API, which has subsequently been replaced withvolatile_zerofor the non-slice based use cases.This can potentially be DRYed out further with
zeroize_flat_type, which I'd like to explore in a further followup.