Repository navigation
Updates to the Stage1 paths - #938
mattiasotgia wants to merge 5 commits into
Conversation
cerati
left a comment
There was a problem hiding this comment.
looks good. There is still the opportunity to clean up a bit spine_gaushit_parameters but that can be done once those parameters are finalized
|
trigger build larsoft@v10_31_00 LArSoft/lar*@LARSOFT_SUITE_v10_31_00 SBNSoftware/sbnalg@v10_31_00_02 SBNSoftware/sbnobj@v10_31_00_02 SBNSoftware/sbnanaobj@v10_31_00_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06_01 SBNSoftware/sbncode@v10_31_00_02 SBNSoftware/icarusalg@v10_31_00_02 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e28:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e28:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
Overview and references
This PR re-work the
stage1paths for Pandora + NuGraph2 + Pandora and SPINE reconstruction.Details are in SBN DocDB 50214, and where discussed at the ICARUS sim/reco and meeting.
The idea is essentially to split the reconstruction chain into three paths:
cluster3Dwhich is required to haveSpacePoints);Key changes
Stage1 definitions (
stage1_icarus_defs.fcl)cluster3DCryoW/Eis the SPINE version and reads thegaushitPT2dTPC*hits.pandoraCluster3DCryoW/Eis for Pandora + NG2 + Pandora and reads the plaingaushit2dTPC*hits.icarus_reco_pandoraCluster3DCryo{W,E}sequences and to theGauss2Dsequences.gaushitPT2dTPC*hit finders now take a sharedspine_gaushit_parametersblock instead of justLongMaxHits. It adds back the default values for the hit finder algorithm (MaxMultiHit: 5,hi2NDF: 500.,LongPulseWidth: [10, 10, 10]) as well as the default for the candidate-hit tool (RoiThreshold: 5.andNextADCThreshold: 0).pandoraGausCryo*input is nowpandoraCluster3DCryo*.Stage1 data and MC job configs
*_1d_*) also set thegaushit1d*tags forpandoraCluster3D*, so Pandora with 1D signal processing uses them too.stage1_run2_icarus.fcland its_MCversion) pointpandoraGausCryo*back tocombineHits*.pandoraCluster3D*forpandoraGausCryo*.NuGraph (
nugraph_icarus.fcl)SpsLabel,ClusterLabeland thehitInputlabels for the slice-hit, NCC-slice and multi-slice modules now usepandoraCluster3DCryo*, aligned with the Pandora-specific Cluster3D instance.Notes
This PR overrides (and expands) the previous PR