Skip to content

Updates to the Stage1 paths - #938

Open
mattiasotgia wants to merge 5 commits into
developfrom
feature/msotgia_hf_spine_reapply_v10_31_00_02
Open

mattiasotgia wants to merge 5 commits into
developfrom
feature/msotgia_hf_spine_reapply_v10_31_00_02

Conversation

@mattiasotgia

@mattiasotgia mattiasotgia commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Overview and references

This PR re-work the stage1 paths for Pandora + NuGraph2 + Pandora and SPINE reconstruction.
Details are in SBN DocDB 50214, and where discussed at the ICARUS sim/reco and meeting.

The idea is essentially to split the reconstruction chain into three paths:

  • "vanilla" Pandora, which takes as input the hits produced using the updated hit finder tuning (Tuned hit finder parameters #912);
  • Pandora + NG2 + Pandora, which take as input the hits produced using the updated hit finder tuning as well (but using cluster3D which is required to have SpacePoints);
  • SPINE, which is using the "old" not-tuned hit finder parameters.

Key changes

Stage1 definitions (stage1_icarus_defs.fcl)

  • Splits Cluster3D into two chains:
    • cluster3DCryoW/E is the SPINE version and reads the gaushitPT2dTPC* hits.
    • New pandoraCluster3DCryoW/E is for Pandora + NG2 + Pandora and reads the plain gaushit2dTPC* hits.
  • Moves the Cluster3D settings into inline tables, replacing the old per-field overrides.
  • The new modules are added to the filter sequences, to new icarus_reco_pandoraCluster3DCryo{W,E} sequences and to the Gauss2D sequences.
  • The gaushitPT2dTPC* hit finders now take a shared spine_gaushit_parameters block instead of just LongMaxHits. It adds back the default values for the hit finder algorithm (MaxMultiHit: 5, hi2NDF: 500., LongPulseWidth: [10, 10, 10]) as well as the default for the candidate-hit tool (RoiThreshold: 5. and NextADCThreshold: 0).
  • The default pandoraGausCryo* input is now pandoraCluster3DCryo*.

Stage1 data and MC job configs

  • The 1D configs (*_1d_*) also set the gaushit1d* tags for pandoraCluster3D*, so Pandora with 1D signal processing uses them too.
  • The Pandora-only configs (stage1_run2_icarus.fcl and its _MC version) point pandoraGausCryo* back to combineHits*.
  • The NuGraph configs use pandoraCluster3D* for pandoraGausCryo*.

NuGraph (nugraph_icarus.fcl)

SpsLabel, ClusterLabel and the hitInput labels for the slice-hit, NCC-slice and multi-slice modules now use pandoraCluster3DCryo*, aligned with the Pandora-specific Cluster3D instance.

Notes

This PR overrides (and expands) the previous PR

@mattiasotgia mattiasotgia self-assigned this Nov 12, 2026
@mattiasotgia mattiasotgia added bug Something isn't working breaking this change will break backward compatibility in some way labels Nov 12, 2026

@cerati cerati left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. There is still the opportunity to clean up a bit spine_gaushit_parameters but that can be done once those parameters are finalized

@jas1005

jas1005 commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

trigger build larsoft@v10_31_00 LArSoft/lar*@LARSOFT_SUITE_v10_31_00 SBNSoftware/sbnalg@v10_31_00_02 SBNSoftware/sbnobj@v10_31_00_02 SBNSoftware/sbnanaobj@v10_31_00_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06_01 SBNSoftware/sbncode@v10_31_00_02 SBNSoftware/icarusalg@v10_31_00_02

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e28:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e28:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking this change will break backward compatibility in some way bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants