Repository navigation
Gen2 Production PR: Update to SBND LightPropagation Module - #967
aantonakis merged 4 commits into
Conversation
…nment
cafmakerjob_sbnd_data_sce.fcl was not remapping CorrectedOpFlashLabel to
its SCE variant, so CAFMaker's association lookup used a label nothing
produced ("lightpropagationcorrection" instead of
"lightpropagationcorrectionSCE"), leaving correctedOpFlash.* at the
-9999. sentinel in data.
LightPropagationCorrection_module now reads the sbnd::timing::FrameShiftInfo
product (produced by FrameShift_module, reordered earlier in
reco2_data.fcl's physics.reco2 path) instead of computing its own shift
from raw SPECTDC RWM/trigger hits. This picks up the RWM-to-gate alignment
FrameShift_module already applies (including the ~1738ns BNBLight mean)
and is stream-agnostic (BNB/Offbeam/Xmuon) since FrameApplyAtCaf is
resolved per-stream upstream. The FrameShiftInfo read is now done once per
event before the slice loop rather than once per slice.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Pinging @fjnicolas as reviewer since @VCLanNguyen and myself are PR authors. |
|
trigger build ci_ref=v10_14_02_09 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_06 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_10 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Hi @fjnicolas, we are hoping to merge this PR soon. I just wanted to reach out to see if you could give this a review? Thanks! |
fjnicolas
left a comment
There was a problem hiding this comment.
Looks good to me! Just two minor suggestions/comments. If time pressing, I'm happy to merge the PR as it is.
|
|
||
| double spToCathode; | ||
| double cathodeToOpDet; | ||
| if(fIsMC){ // Correct VIS light as is simulated in MC. |
There was a problem hiding this comment.
Can you add a link to the docdb explaining the difference between the data/MC approaches? It's non trivial, so it'd be nice for future reference.
| if(fIsMC){ // Correct VIS light as is simulated in MC. | |
| if(fIsMC){ // Correct VIS light as is simulated in MC (docdb 49900). |
| _fNuScore = 0.0; | ||
| fRWMTime=0.; | ||
| fEventTriggerTime=0.; | ||
| fFrameApplyAtCaf=0.; |
There was a problem hiding this comment.
I found the name of the variable confusing while making the review. The correction is all applied within this module, right? There is no correction left to be done by the user at CAF level.
There was a problem hiding this comment.
Gen2 overall still needs time correction at CAF-level... It just happens this one timing variable sbn::CorrectedOpFlash will get correction at reco2 instead CAF.
So this naming method is to stay consistent with what being done in CAF, see these lines: https://github.com/SBNSoftware/sbncode/blob/production/sbnd-gen2/sbncode/CAFMaker/CAFMaker_module.cc#L645-L674
|
trigger build ci_ref=v10_14_02_09 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_06 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_10 |
|
❌ CI build for LArSoft Failed at phase build LArSoft on slf7 for e28:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build LArSoft phase logs |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
Description
Relevant PR links (optional)
sbndcode: #967
sbncode: SBNSoftware/sbncode#675
sbnanaobj: SBNSoftware/sbnanaobj#199
Link(s) to docdb describing changes (optional)
See slide 27-29 on docdb#49588
Checklist
Reviewers,AssigneesDevelopement