Skip to content

Include QE lambda reconstruction framework on reco2 workflow - #998

Open
SergioYB wants to merge 2 commits into
production/sbnd-gen2from
feature/qe_lambda_reco
Open

SergioYB wants to merge 2 commits into
production/sbnd-gen2from
feature/qe_lambda_reco

Conversation

@SergioYB

@SergioYB SergioYB commented Nov 20, 2026 •

Copy link
Copy Markdown

Description

Please provide a detailed description of the changes this pull request introduces.

This PR introduces a set of modules to reconstruct and include in CAFs the variables used in the qe lambda analysis.
They are included in the reco2 workflow by adding the stages FRANSProducer, pandoraLambda, pandoraTrackLambda, pandoraCaloLambda, pandoraPidLambda, LambdaPID at its end.

reco2_data.fcl includes the equivalent FRANSProducerData, pandoraLambdaData, pandoraTrackLambdaData, pandoraCaloLambdaData, pandoraPidLambdaData, LambdaPIDData that use the appropriate data labels.

$${\color{blue}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{blue}\bf{\textrm{IMPORTANT UPDATE Feb 2nd 2026:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production for gen 2 SBND analyses, you must make two PRs: one for develop and one for the production/sbnd-gen2 branch.

$${\color{blue}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

  • [x ] Added at least 1 label from available labels.
  • [x ] Assigned at least 1 reviewer under Reviewers,
  • [x ] Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • [x ] Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or tjones79) as additional reviewer.
  • [x ] Does this affect the standard workflow?
  • [x ] Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
sbnobj
sbnanaobj
sbncode

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

Plan for integrating Lambda reconstruction on Gen2 respin

@SergioYB SergioYB self-assigned this Nov 20, 2026
@SergioYB SergioYB added the reco1/reco2 Reconstruction label Nov 20, 2026
@SergioYB SergioYB changed the title Feature/qe lambda reco Include QE lambda reconstruction framework on reco2 workflow Nov 20, 2026
@SergioYB
SergioYB marked this pull request as ready for review November 20, 2026 13:02
@Jjm321814

Copy link
Copy Markdown
Contributor

Golly thats a lot of file changes.
To be clear on what things should work here:

  • FRANS producer module that adds hits, hit associations, a custom Lambda object, and some MC truth info. When should this module run? After/during reco2 by the changes to reco2 configs.
  • I don't love the LambdaReconstruction/src/Analysis folder being in sbndcode. None of that is LArSoft, and it means we have src folders in our src folder! I think these should get moved into their own repo for tracking. Relatedly I don't know how to think about anything in the LambdaReconstruction/scripts. Are these xml files needed for the producers? If we can roll out this to a different repo then this becomes like ~15 files with changes/new files so its a lot more feasible to dig into all the code.
  • Granted I am in a glass house on this, but we rerun pandora again with slightly different settings/inputs. This will be the third instance of pandora running on reco2, with regular, special blip, and now special lambda. We should monitor how that changes the reco2 job requirements. I won't hold up approval on fixing that but we should be thinking about it.

Do you have a collection of nice reco1 or reco2 files we can run this over so that the variables added should be filled with good information? We can test running it in a new area then.
Also please bring the branch up to date with develop. The button in this PR should probably be able to manage that but there might be a conflict I am not thinking about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reco1/reco2 Reconstruction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants