Repository navigation
fix(plan): account for stored parent changes when categorizing indirect snapshots #6214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dcohen24
wants to merge
6
commits into
SQLMesh:main
Choose a base branch
from
dcohen24:fix/stored-parent-indirect-categorization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,090
−14
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7e67cba
fix(plan): account for stored parent changes when categorizing indire…
dcohen24 bbf0a61
fix(plan): include stored parents in the forward-only decision
dcohen24 0162ab2
fix(plan): don't let metadata or non-breaking changes veto forward-on…
dcohen24 19c72ed
fix(plan): decide forward-only from every breaking version of a store…
dcohen24 64a9618
fix(plan): read the forward-only flag of stored parent versions from …
dcohen24 f4a943c
fix(plan): limit the stored-parent forward-only vote to breaking history
dcohen24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gate is true whenever any stored direct parent changed, including a metadata-only or non-breaking change. A stored parent with no breaking history then switches the forward-only rule for the new parents too, which I think is the both-new behavior the description says is left for a follow-up.
Repro: child c has parents a (stored, changed only owner), b (new, forward-only BREAKING) and d (new, NON_BREAKING). On main, and on this PR when a is unchanged, c is rebuilt. On this PR, when a has only the metadata change, c is forward-only and keeps its old version. So the same b + d change gives the opposite result depending on whether a third parent had an owner change applied in dev.
Gating on stored_parent_forward_only instead fixes it. That set is only non-empty when a stored parent has a breaking version, so initialize it to set(). With this change all of test_plan.py and test_change_scenarios.py still pass, and the repro matches main. Could you add the repro as a test too? (The comment includes the code change and the full parametrized repro test.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as the
builder.pycomment (the gate), addressed there in f4a943c.