You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Flake: an_interrupt_pass_ends_the_whole_build_group fails on macOS ("the pass reaped the build's child itself") #2088
[agent] PR shepherd: the nightly CI schedule run on main (63f791d) failed test (macos-latest, 1) on one core unit test:
utils::process::tests::an_interrupt_pass_ends_the_whole_build_group ... FAILED
panicked at crates/socket-patch-core/src/utils/process.rs:1223:9:
the pass reaped the build's child itself
test result: FAILED. 7736 passed; 1 failed
The assertion at process.rs:1221-1224 expects child.try_wait() to return Err (the child was already reaped). On macOS, try_wait seems to return Ok(..) sometimes, so the test races with whatever reaps the child, or with how macOS reports a reaped zombie.
The other red job in that run (test (windows-latest, 1)) is #2080, fixed by #2082.
Expected fix: make the assertion robust to how macOS reports a reaped child. Don't skip or weaken what the test checks: that the interrupt pass ends the whole group without reaping the build's direct child.
Activity