Repository navigation
Implement embeddings for the OpenRouter provider - #720
Merged
TonsOfFun merged 1 commit intoNov 19, 2026
Merged
Conversation
OpenRouterProvider inherits ChatProvider, which defines neither embed_request_type nor api_embed_execute, so embed raised NotImplementedError. Add both, mirroring RequestyProvider.
yorzi
pushed a commit
to yorzi/activeagent
that referenced
this pull request
Nov 19, 2026
…tool-choice-required CHANGELOG: the 1.9.9 section is released, so the entries from activeagents#721 and activeagents#722 move to a new Unreleased section, with entries added for activeagents#712 and activeagents#720. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PCEJHngWphRQ7ArmDnYMmf
yorzi
pushed a commit
to yorzi/activeagent
that referenced
this pull request
Nov 19, 2026
…-1.9.10 Land the community provider fixes activeagents#712, activeagents#720, activeagents#721, activeagents#722
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenRouterProviderinherits fromOpenAI::ChatProvider, which does not defineembed_request_type, and it never definesapi_embed_execute.embedtherefore raisesNotImplementedError(not aStandardError, so it also bypasses the provider's exception handling) even though OpenRouter serves an OpenAI-compatible/embeddingsendpoint.This adds
embed_request_type(OpenAI embedding request type) andapi_embed_execute(client.embeddings.create), the same wayRequestyProviderdoes.Test:
test/providers/open_router/embed_test.rbstubshttps://openrouter.ai/api/v1/embeddingsand checks the vectors and the bearer header. It fails onmainwithNotImplementedErrorand passes with the change.test/providers/open_router/*: 28 runs, 0 failures.This change was made with Claude Code; the tests above were run on the branch.
🤖 Generated with Claude Code