Repository navigation
Conversation
The adapter read tool_choice only to clear it between turns and never sent it, so tool_choice: "required" (or a named tool) was ignored and a generation could end without any tool call. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
yorzi
pushed a commit
to yorzi/activeagent
that referenced
this pull request
Nov 19, 2026
…-1.9.10 Land the community provider fixes activeagents#712, activeagents#720, activeagents#721, activeagents#722
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RubyLLMProviderreadtool_choiceonly forToolChoiceClearing(to drop it after the tool was used) and never put it in theprovider.completecall. Sotool_choice: "required", or a named tool, was silently ignored and a generation could finish without calling any tool even though the caller required one.The adapter now sends it as RubyLLM's
tool_prefs: { choice: }(:required,:auto,:none, or the tool name), only when the request has tools. OnceToolChoiceClearinghas cleared it after the tool ran, later turns send nothing, so the tool loop still ends. RubyLLM 1.x and 2.x both accepttool_prefs.Test:
test/providers/ruby_llm/ruby_llm_provider_test.rbgets three cases (required, a named tool, none set); the first two fail onmainwithtool_prefsmissing. The RubyLLM provider, wire-format and streaming test files pass on bothruby_llm_1andruby_llm_2gemfiles. A CHANGELOG entry is included.This change was made with Claude Code; the tests above were run on the branch.
🤖 Generated with Claude Code