Repository navigation
Implement embeddings for the Azure OpenAI provider - #725
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
AzureProvider declares embed_request_type but never defined api_embed_execute, so embed raised NotImplementedError. Call the Azure client's embeddings endpoint like the other OpenAI-compatible providers.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AzureProviderdeclaresembed_request_type, soembedbuilds the request, but it never definesapi_embed_execute. The base implementation raisesNotImplementedError, which is not aStandardError, so it also escapes the provider's exception handling and callers get no vectors. OpenAI, Requesty, Opper, Gemini and CheaperInference all implement the method.This adds
api_embed_executetoAzureProvider, callingclient.embeddings.createon the Azure client, so the request goes to the deployment's/embeddingsendpoint with theapi-keyheader andapi-versionquery.Test:
test/providers/azure/embed_test.rbstubs the deployment embeddings endpoint and checks the vectors and theapi-key/api-version. It exercises the new method (onmainthe call raisesNotImplementedError).This change was made with Claude Code.
🤖 Generated with Claude Code