Repository navigation
Conversation
|
I can't seem to figure out how to get this to build... |
|
Thanks for taking a look at this! FYI, upstream has had some security patches since 1.9.5, so the goal for this PR should be to update to 1.9.7 instead. My strategy for doing these upgrades is to get the diff between versions of the cmake files and make changes based off that. |
Our config header was missing some variables and defining unecessary ones. The source files were missing some definitions from SelectRegex.cmake. GIT_REGEX_PCRE2 flag is only used if linking system pcre2.
|
Main library builds now, CI is failing to build the test runner. Even when we get the test runner building I'd like to do a pass checking the cmake diffs, as some important configuration changes could have slipped through. |
Done
Sounds good. I tested it in my program and it did not fix my error. I could be using it wrong. Either way that means that I am no rush for this to be updated now. I might look into the cmake diffs when I get a chance. |
Trying to see how far I can bump libgit to see if it fixes a wired error I am getting where it says I dont have
$HOME/.gitconfigfile (which I should not need as I have a$XDG_CONFIG_HOME/git/configfile).