Repository navigation
Conversation
…er chain Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2659.
The
RewriteHandlerwas added to theContextscollection as a sibling of the webapps, so none of its header rules ran; it is now inserted at theServerlevel like the other wrappers, in both the shipped and the testjetty-webapps.xml. With the CSP now actually sent, the three inlineonclickconfirms inbrowse.jspandmessage.jspwould be blocked, so they move tojs/browse.jsandjs/message.jsas the review on #2676 asked.JettyServerBeanTestnow logs in through a testPropertiesLoginModuleconfig and checks for a 200 carryingX-Frame-Options(it fails without the XML change).