Skip to content

Fail tests when the expected exception is missing - #148

Open
sharanggupta wants to merge 1 commit into
apache:masterfrom
sharanggupta:fail-when-no-exception
Open

sharanggupta wants to merge 1 commit into
apache:masterfrom
sharanggupta:fail-when-no-exception

Conversation

@sharanggupta

Copy link
Copy Markdown

testIOException and testNullCheckValueExceptionMessage asserted only inside the catch block, so they passed when nothing was thrown. This adds the missing fail(). With the null check or the charset IOException removed, the old tests still pass and the new ones fail.

testIOException and testNullCheckValueExceptionMessage only asserted
inside the catch block, so they passed when nothing was thrown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant