Skip to content

ci: gate manual docs releases on the built commit - #1266

Merged
B4nan merged 2 commits into
masterfrom
ci/docs-release-check-built-commit
Nov 18, 2026
Merged

B4nan merged 2 commits into
masterfrom
ci/docs-release-check-built-commit

Conversation

@vdusek

@vdusek vdusek commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

The Wait for checks step in manual_release_docs.yaml waited for checks on github.sha, but the job builds and deploys the docs from inputs.ref. A manual run with ref set to another commit was gated on the wrong commit.

  • The gate now runs after the checkout and waits for checks on the commit that was checked out.
  • A manual run also checks that this commit is on master or a release-v* branch, like publish_to_pypi.yaml does.
  • The release workflows that call this workflow skip both steps through the new skip_checks input. They have their own gate. github.event_name in a called workflow is the caller's event, so the old workflow_dispatch condition also ran the gate inside dispatched releases.

✍️ Drafted by Claude Code

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Nov 18, 2026
@vdusek vdusek self-assigned this Nov 18, 2026
@codecov

codecov Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.88%. Comparing base (bbebcf2) to head (6b54f52).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1266   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files          54       54           
  Lines        3893     3893           
=======================================
  Hits         3655     3655           
  Misses        238      238           
Flag Coverage Δ
e2e 31.08% <ø> (ø)
integration 50.70% <ø> (ø)
unit 91.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek changed the title ci: check the built commit before a manual docs release ci: gate manual docs releases on the built commit Nov 18, 2026
@vdusek
vdusek marked this pull request as ready for review November 18, 2026 15:03
@vdusek
vdusek requested a review from B4nan November 18, 2026 15:03
@B4nan
B4nan merged commit e63d023 into master Nov 18, 2026
42 checks passed
@B4nan
B4nan deleted the ci/docs-release-check-built-commit branch November 18, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants