Repository navigation
Bump the basecamp/mcp toolkit, and sync the catalog that titles its tools - #230
Merged
Merged
Conversation
…ools Move github.com/basecamp/mcp from the 2026-08-28 pin (2d6f44b) to 663b2e5, which carries the result paging and size-cap middleware and the eval multi-turn mode. go-sdk moves with it to the toolkit's own pin. The toolkit's gateway.Domain grew ToolTitle, AllIdempotent and AnyDestructive, and the gateway now derives every tool's annotations (title, idempotent, destructive, closed world) from them and refuses a domain without a title. The vendored catalog predated that, so it no longer satisfied the interface. Re-sync it with scripts/sync-mcp-catalog.sh from fizzy-mcp-server 724955b, the commit that adopted those annotations there: every domain gets a "Fizzy ..." title, every read and the provably converging writes are idempotent, and the delete_* actions plus unpublish_board are destructive. The snapshot delta is exactly the new "destructive" notes and fields. The sync stops at 724955b rather than the sibling's head. Later catalog changes there (top-level body fields, read-only blurbs) need matching dispatch and server changes here, so they are a port of their own. The CLI's catalog tests take the sibling's matching changes: titled fixtures, the three new validate refusals, and the drift test pinning the destructive curation to the toolkit's bridge classifier.
Contributor
There was a problem hiding this comment.
🟢 Approved
No active review issues are recorded for the MCP toolkit upgrade and catalog synchronization.
No open issues 🎉
What changed in this PR
Updates the MCP toolkit and synchronizes Fizzy CLI’s vendored catalog to satisfy the new gateway interface, including tool titles and operation safety annotations.
Changes:
- Bumps
basecamp/mcpand aligns the MCP Go SDK with the toolkit’s pin. - Syncs catalog titles, idempotent/destructive annotations, and provenance from sibling commit
724955b. - Adds annotation validation and drift coverage, and refreshes the catalog snapshot.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
internal/mcpserver/catalog/testdata/catalog_snapshot.txt |
Records new annotation fields and destructive labels. |
internal/mcpserver/catalog/PROVENANCE.json |
Updates the catalog’s upstream source commit. |
internal/mcpserver/catalog/domains.go |
Adds domain titles and operation safety annotations. |
internal/mcpserver/catalog/catalog.go |
Implements the gateway interface additions, annotation output, and validation. |
internal/mcpserver/catalog/catalog_test.go |
Tests annotation validation and destructive-classifier consistency. |
go.sum |
Updates checksums for the bumped dependencies. |
go.mod |
Pins the newer toolkit and matching MCP Go SDK. |
Review effort: Balanced
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
github.com/basecamp/mcpfrom the 2026-08-28 pin (2d6f44b) to663b2e5. go-sdk moves with it to the toolkit's own pin.What broke
gateway.DomaingainedToolTitle,AllIdempotentandAnyDestructive. The gateway now derives each tool's annotations from them (title, idempotent, destructive, and open-world false), and it refuses a domain that has no title. The vendored catalog was older than that change, so*catalog.Domainno longer satisfied the interface and the build failed.Fix
I re-synced the catalog with
scripts/sync-mcp-catalog.shfrom fizzy-mcp-server724955b, the commit where the sibling adopted these annotations. The copy stays verbatim andPROVENANCE.jsonnames that commit. The sync brings:Fizzy …title on every domainIdempotenton every read, on the PUT-style updates and onpublish_boardDestructiveon thedelete_*actions and onunpublish_boarddestructivenote in descriptions and describe summariesThe snapshot changes only by those new notes and fields.
The sync stops at
724955b, not the sibling's head. Later catalog changes there (top-level body fields, read-only blurbs) need matching dispatch and server changes in this repo, so they belong in a port of their own.catalog_test.gopicks up the sibling's matching test changes:validaterefusals: missing title, a read not marked idempotent, a read marked destructiveChecks
make checkpasses. Lint ran at CI's golangci-lint v2.10. A local v2.15 flags two gosec G124 findings insignup.go, which this PR doesn't touch; CI's version doesn't report them.Summary by cubic
Bumps the
basecamp/mcptoolkit and re-syncs the vendored catalog so it satisfies the toolkit's newgateway.Domaincontract.go-sdkmoves with it to the toolkit's own pin.The newer toolkit requires every domain to provide a
ToolTitle, anAllIdempotentcheck, and anAnyDestructivecheck, and refuses any domain without a title. The catalog predated that, so the build failed. Re-syncing viascripts/sync-mcp-catalog.shbrings it in line, and validation now rejects reads not marked idempotent and reads marked destructive.Catalog passes
Fizzy …title.publish_boardare idempotent.delete_*actions andunpublish_boardare destructive, with matching description notes and snapshot updates.The sync stops at the sibling's commit that introduced these annotations; later catalog changes there need matching dispatch and server changes and land separately.
Written for commit c4c9b4d. Summary will update on new commits.