Skip to content

Bump the basecamp/mcp toolkit, and sync the catalog that titles its tools - #230

Merged
jeremy merged 1 commit into
masterfrom
bump-mcp-toolkit
Nov 19, 2026
Merged

jeremy merged 1 commit into
masterfrom
bump-mcp-toolkit

Conversation

@jeremy

@jeremy jeremy commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Moves github.com/basecamp/mcp from the 2026-08-28 pin (2d6f44b) to 663b2e5. go-sdk moves with it to the toolkit's own pin.

What broke

gateway.Domain gained ToolTitle, AllIdempotent and AnyDestructive. The gateway now derives each tool's annotations from them (title, idempotent, destructive, and open-world false), and it refuses a domain that has no title. The vendored catalog was older than that change, so *catalog.Domain no longer satisfied the interface and the build failed.

Fix

I re-synced the catalog with scripts/sync-mcp-catalog.sh from fizzy-mcp-server 724955b, the commit where the sibling adopted these annotations. The copy stays verbatim and PROVENANCE.json names that commit. The sync brings:

  • a Fizzy … title on every domain
  • Idempotent on every read, on the PUT-style updates and on publish_board
  • Destructive on the delete_* actions and on unpublish_board
  • the destructive note in descriptions and describe summaries

The snapshot changes only by those new notes and fields.

The sync stops at 724955b, not the sibling's head. Later catalog changes there (top-level body fields, read-only blurbs) need matching dispatch and server changes in this repo, so they belong in a port of their own.

catalog_test.go picks up the sibling's matching test changes:

  • titled fixtures
  • three new validate refusals: missing title, a read not marked idempotent, a read marked destructive
  • a drift test that pins destructive curation to the toolkit's bridge classifier

Checks

make check passes. Lint ran at CI's golangci-lint v2.10. A local v2.15 flags two gosec G124 findings in signup.go, which this PR doesn't touch; CI's version doesn't report them.


Summary by cubic

Bumps the basecamp/mcp toolkit and re-syncs the vendored catalog so it satisfies the toolkit's new gateway.Domain contract. go-sdk moves with it to the toolkit's own pin.

The newer toolkit requires every domain to provide a ToolTitle, an AllIdempotent check, and an AnyDestructive check, and refuses any domain without a title. The catalog predated that, so the build failed. Re-syncing via scripts/sync-mcp-catalog.sh brings it in line, and validation now rejects reads not marked idempotent and reads marked destructive.

Catalog passes

  • Every domain gets a Fizzy … title.
  • Reads, PUT-style updates, and publish_board are idempotent.
  • delete_* actions and unpublish_board are destructive, with matching description notes and snapshot updates.
  • A drift test pins destructive curation to the toolkit's bridge classifier.

The sync stops at the sibling's commit that introduced these annotations; later catalog changes there need matching dispatch and server changes and land separately.

Written for commit c4c9b4d. Summary will update on new commits.

View guided diff Turn on auto-fix

…ools

Move github.com/basecamp/mcp from the 2026-08-28 pin (2d6f44b) to 663b2e5,
which carries the result paging and size-cap middleware and the eval
multi-turn mode. go-sdk moves with it to the toolkit's own pin.

The toolkit's gateway.Domain grew ToolTitle, AllIdempotent and
AnyDestructive, and the gateway now derives every tool's annotations
(title, idempotent, destructive, closed world) from them and refuses a
domain without a title. The vendored catalog predated that, so it no longer
satisfied the interface. Re-sync it with scripts/sync-mcp-catalog.sh from
fizzy-mcp-server 724955b, the commit that adopted those annotations there:
every domain gets a "Fizzy ..." title, every read and the provably
converging writes are idempotent, and the delete_* actions plus
unpublish_board are destructive. The snapshot delta is exactly the new
"destructive" notes and fields.

The sync stops at 724955b rather than the sibling's head. Later catalog
changes there (top-level body fields, read-only blurbs) need matching
dispatch and server changes here, so they are a port of their own.

The CLI's catalog tests take the sibling's matching changes: titled
fixtures, the three new validate refusals, and the drift test pinning the
destructive curation to the toolkit's bridge classifier.
Copilot AI balanced review requested due to automatic review settings November 19, 2026 01:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

No active review issues are recorded for the MCP toolkit upgrade and catalog synchronization.

No open issues 🎉

What changed in this PR

Updates the MCP toolkit and synchronizes Fizzy CLI’s vendored catalog to satisfy the new gateway interface, including tool titles and operation safety annotations.

Changes:

  • Bumps basecamp/mcp and aligns the MCP Go SDK with the toolkit’s pin.
  • Syncs catalog titles, idempotent/destructive annotations, and provenance from sibling commit 724955b.
  • Adds annotation validation and drift coverage, and refreshes the catalog snapshot.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File Description
internal/​mcpserver/​catalog/​testdata/​catalog_snapshot.txt Records new annotation fields and destructive labels.
internal/​mcpserver/​catalog/​PROVENANCE.json Updates the catalog’s upstream source commit.
internal/​mcpserver/​catalog/​domains.go Adds domain titles and operation safety annotations.
internal/​mcpserver/​catalog/​catalog.go Implements the gateway interface additions, annotation output, and validation.
internal/​mcpserver/​catalog/​catalog_test.go Tests annotation validation and destructive-classifier consistency.
go.sum Updates checksums for the bumped dependencies.
go.mod Pins the newer toolkit and matching MCP Go SDK.

Review effort: Balanced

@jeremy

jeremy commented Nov 19, 2026

Copy link
Copy Markdown
Member Author

Review threads: none. Copilot approved on c4c9b4d with no findings.
Not reported on the head: cubic, c4c9b4d (its check ended neutral: the monthly review limit is reached, so it reviewed nothing).

@jeremy
jeremy merged commit b4a4086 into master Nov 19, 2026
17 checks passed
@jeremy
jeremy deleted the bump-mcp-toolkit branch November 19, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants