Skip to content

worked around a MacOS ABI issue - #347

Merged
dietmarkuehl merged 1 commit into
mainfrom
fix-macos-abi-issue-in-test
Nov 19, 2026
Merged

dietmarkuehl merged 1 commit into
mainfrom
fix-macos-abi-issue-in-test

Conversation

@dietmarkuehl

Copy link
Copy Markdown
Member

No description provided.

@dietmarkuehl
dietmarkuehl marked this pull request as ready for review November 19, 2026 18:54
@dietmarkuehl
dietmarkuehl requested a review from camio as a code owner November 19, 2026 18:54
Copilot AI balanced review requested due to automatic review settings November 19, 2026 18:54
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 92.992%. remained the same — fix-macos-abi-issue-in-test into main

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The change introduces a user-provided destructor as a macOS ABI workaround, but the review notes it still needs validation on affected macOS toolchains to confirm it resolves the ABI issue without unintended ABI or type-trait side effects such as disabling moves.

No open issues 🎉

What changed in this PR

Works around a macOS ABI issue in a test-only operation-state helper by introducing an explicit destructor in the test_basic_state specialization used for inlinable receivers.

Changes:

  • Add a user-provided (empty) destructor to test_basic_state<Sndr, Rcvr> when Rcvr satisfies test_std::inlinable_receiver.
  • Add an inline comment documenting the workaround.
File Description
tests/​beman/​execution/​exec-recv-concepts.test.cpp Adds an explicit (empty) destructor to the inlinable-receiver test_basic_state specialization as a macOS ABI workaround and documents it inline.

Review effort: Balanced
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.

@dietmarkuehl
dietmarkuehl merged commit 976a337 into main Nov 19, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants