Repository navigation
worked around a MacOS ABI issue - #347
Merged
Merged
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
The change introduces a user-provided destructor as a macOS ABI workaround, but the review notes it still needs validation on affected macOS toolchains to confirm it resolves the ABI issue without unintended ABI or type-trait side effects such as disabling moves.
No open issues 🎉
What changed in this PR
Works around a macOS ABI issue in a test-only operation-state helper by introducing an explicit destructor in the test_basic_state specialization used for inlinable receivers.
Changes:
- Add a user-provided (empty) destructor to
test_basic_state<Sndr, Rcvr>whenRcvrsatisfiestest_std::inlinable_receiver. - Add an inline comment documenting the workaround.
| File | Description |
|---|---|
| tests/beman/execution/exec-recv-concepts.test.cpp | Adds an explicit (empty) destructor to the inlinable-receiver test_basic_state specialization as a macOS ABI workaround and documents it inline. |
Review effort: Balanced
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.