Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 24b0e1c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
spinnerread the terminal width once, when it was created, and worked out how many lines to clear from the raw message only (without the◒frame prefix, dots or timer). So when the terminal got narrower while the spinner was running, or when the frame itself wrapped, it cleared too few lines and old frames stacked up on screen.It now keeps the frame it last wrote and re-wraps it at the current width before clearing. Each new frame is also wrapped at the current width. This is the same approach
Prompt.restoreCursorin core already uses.progressis built onspinner, so it gets the fix too.Closes #132
Type of change
Checklist
pnpm testpasses (or targeted tests for my change) — spinner tests pass (66/66; the 4 new ones fail without the fix); the 4note.test.tssnapshot failures also happen onmainlocallypnpm formathas been runAI-generated code disclosure
Note: open PR #584 also touches the spinner's wrapping code; this change is separate, but one of them may need a small rebase if both land. Tested with mocked output only, not in a real resizing terminal.