Repository navigation
Add shared DOM lookup and live collections #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@clack/ui': patch | ||
| --- | ||
|
|
||
| Add document ID lookup in tree order and live tag-name collections with indexed own properties, covered by original upstream Web Platform Tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| import type { Element } from './dom.ts'; | ||
|
|
||
| const sources = new WeakMap<HTMLCollection, () => Element[]>(); | ||
|
|
||
| export class HTMLCollection implements Iterable<Element> { | ||
| readonly [index: number]: Element; | ||
|
|
||
| constructor(elements: () => Element[]) { | ||
| sources.set(this, elements); | ||
| const collection = new Proxy(this, { | ||
| get(target, key, receiver) { | ||
| if (isArrayIndex(key)) { | ||
| return elements()[Number(key)] ?? Reflect.get(target, key, receiver); | ||
| } | ||
| if (typeof key === 'string' && !(key in target)) { | ||
| return namedElement(elements(), key) ?? undefined; | ||
| } | ||
| return Reflect.get(target, key, receiver); | ||
| }, | ||
| has(target, key) { | ||
| if (isArrayIndex(key) && Number(key) < elements().length) { | ||
| return true; | ||
| } | ||
| return Reflect.has(target, key); | ||
| }, | ||
| getOwnPropertyDescriptor(target, key) { | ||
| if (isArrayIndex(key)) { | ||
| const element = elements()[Number(key)]; | ||
| if (element !== undefined) { | ||
| return { value: element, writable: false, enumerable: true, configurable: true }; | ||
| } | ||
| } | ||
| return Reflect.getOwnPropertyDescriptor(target, key); | ||
| }, | ||
| ownKeys(target) { | ||
| const indices = elements().map((_, index) => `${index}`); | ||
| return [...indices, ...Reflect.ownKeys(target)]; | ||
| }, | ||
| set(target, key, value, receiver) { | ||
| if (isArrayIndex(key) && Number(key) < elements().length) { | ||
| return false; | ||
| } | ||
| return Reflect.set(target, key, value, receiver); | ||
| }, | ||
| defineProperty(target, key, descriptor) { | ||
| if (isArrayIndex(key)) { | ||
| return false; | ||
| } | ||
| return Reflect.defineProperty(target, key, descriptor); | ||
| }, | ||
| deleteProperty(target, key) { | ||
| if (isArrayIndex(key)) { | ||
| return Number(key) >= elements().length; | ||
| } | ||
| return Reflect.deleteProperty(target, key); | ||
| }, | ||
| preventExtensions() { | ||
| // Live indices must remain able to appear and disappear. | ||
| return false; | ||
| }, | ||
| }); | ||
| sources.set(collection, elements); | ||
| return collection; | ||
| } | ||
|
|
||
| get length(): number { | ||
| return sources.get(this)!().length; | ||
| } | ||
|
|
||
| item(index: number): Element | null { | ||
| return sources.get(this)!()[index >>> 0] ?? null; | ||
| } | ||
|
|
||
| namedItem(name: string): Element | null { | ||
| const key = `${name}`; | ||
| return namedElement(sources.get(this)!(), key); | ||
| } | ||
|
|
||
| *[Symbol.iterator](): IterableIterator<Element> { | ||
| for (let index = 0; index < this.length; index++) { | ||
| yield this.item(index)!; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| function isArrayIndex(key: PropertyKey): key is string { | ||
| return typeof key === 'string' && /^(0|[1-9]\d*)$/.test(key) && Number(key) < 2 ** 32 - 1; | ||
| } | ||
|
Comment on lines
+86
to
+88
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks i hate it |
||
|
|
||
| function namedElement(elements: Element[], name: string): Element | null { | ||
| if (name === '') { | ||
| return null; | ||
| } | ||
| return ( | ||
| elements.find( | ||
| (element) => | ||
| element.id === name || | ||
| (element.namespaceURI === 'http://www.w3.org/1999/xhtml' && | ||
| element.getAttribute('name') === name), | ||
| ) ?? null | ||
| ); | ||
| } | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice! that's a big jump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like the main benefit here is just that selectOne/selectAll do the walking for us?