Repository navigation
Conversation
coder13
marked this pull request as ready for review
November 15, 2026 01:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Official
ftoWCIF data currently throws in competition summaries, round selection, and exports because both the app registry and the shared helper dependency lack event metadata. Add FTO names and ordering, typed/runtime helper support, and an icon alias so registrations, group creation, assignments, imports, and exports use the official ID throughout.Pin and patch
@wca/helpers1.1.6, including the copy used bywca-group-generators. Later helper releases still lack runtime FTO metadata; upgrading to v2 would also require unrelated WCIF schema changes. The patch applies during Yarn installation and fails on application errors; its removal criteria are documented inpatches/README.md. Event filters now expose accessible names and selection state.Pin
.nvmrcto Node 24 and the test jobs to Ubuntu 24.04. Floatinglts/*andubuntu-latestselected Node 26 (native localStorage conflicts with the current jsdom test environment) and Ubuntu 26.04 (unsupported by the locked Playwright version), causing unit-test and browser-install failures in CI.Validation:
yarn testandyarn test:coverage: 400 tests passed across 63 files.yarn test:e2e --workers=2: all 9 browser tests passed, including FTO summary, icon, round editing, assignment generation, save/reload, filtering, and all four CSV downloads.yarn check:typeandyarn build: passed.yarn lint: passed with 0 errors and 20 existing warnings; pre-push type/lint checks also passed.yarn install --frozen-lockfile: patch applied successfully, with direct and transitive FTO helper checks passing.git diff --checkand formatting checks for the new tests passed.Yarn lifecycle scripts must remain enabled to apply the dependency patch.